Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug when editing monitor(type group) #3262

Closed
2 tasks done
devitq opened this issue Jun 13, 2023 · 3 comments · Fixed by #3311
Closed
2 tasks done

Bug when editing monitor(type group) #3262

devitq opened this issue Jun 13, 2023 · 3 comments · Fixed by #3311
Labels
bug Something isn't working
Milestone

Comments

@devitq
Copy link
Contributor

devitq commented Jun 13, 2023

⚠️ Please verify that this bug has NOT been raised before.

  • I checked and didn't find similar issue

🛡️ Security Policy

Description

No response

👟 Reproduction steps

Need to create monitor(type: group), then link some monitors to it, then change type(group to other type)

👀 Expected behavior

...

😓 Actual Behavior

All monitors which was linked are still linked after changing type and we can't unlink them

🐻 Uptime-Kuma Version

1.22.0-beta.0

💻 Operating System and Arch

Replit

🌐 Browser

Google Chrome

🐋 Docker Version

No response

🟩 NodeJS Version

No response

📝 Relevant log output

No response

@devitq devitq added the bug Something isn't working label Jun 13, 2023
@devitq
Copy link
Contributor Author

devitq commented Jun 13, 2023

I suggest just to unlink monitors(which was linked to group) when changing type of group

@louislam
Copy link
Owner

louislam commented Jun 13, 2023

Thank you for testing it, I didn't test this case.

@tarun7singh
Copy link
Contributor

@devitq @louislam Added a fix for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants