PromoSMS: Cannot send message/notification if too long

[Krismm]

⚠️ Please verify that this bug has NOT been raised before.

• I checked and didn't find similar issue

🛡️ Security Policy

• I agree to have read this project Security Policy

📝 Describe your problem

Hi
I have a problem with PromoSMS notifications
PromoSMS does not send Down notifications (sends only Up)

I have additionally configured Email(SMTP) and sends Down and Up there.

Can anything be configured?

🐻 Uptime-Kuma Version

1.9.2

💻 Operating System and Arch

louislam/uptime-kuma:1.9.2-debian-data-2

🌐 Browser

Microsoft Edge Wersja 108.0.1462.54

🐋 Docker Version

louislam/uptime-kuma:1.9.2-debian-data-2

🟩 NodeJS Version

No response

[louislam]

uptime-kuma/server/notification-providers/promosms.js

Line 22 in bc7271b

"text": msg.replace(/[^\x00-\x7F]/g, ""),

Just have a quick look, both up/down notifications sent thought the same function.

@PopcornPanda any idea?

[Krismm]

During the Down event, the following message appears in the console:

`Cannot send notification to XXX-Powiadomienie
Error: Error: Error: Error: Something gone wrong. Api returned 204.  
    at PromoSMS.throwGeneralAxiosError (/app/server/notification-providers/notification-provider.js:32:15)
    at PromoSMS.send (/app/server/notification-providers/promosms.js:36:18)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at async Function.sendNotification (/app/server/model/monitor.js:595:21)
    at async Timeout.beat [as _onTimeout] (/app/server/model/monitor.js:353:17)
Monitor #5 'TerminalXX - XX': Failing: PING 192.168.3.166 (192.168.3.166) 56(84) bytes of data.

--- 192.168.3.166 ping statistics ---
10 packets transmitted, 0 received, 100% packet loss, time 14ms`

That is, the values of the transferred data are incorrect

How can I see what is sent by the API?

[louislam]

Checked PromoSMS API

204 Wiadomość jest dłuższa niż 1 sms

Google Translate:

204 The message is longer than 1 sms

I marked it as bug, see if anyone could fix it.

[Krismm]

Okay, I've got something (debug promosms.js)

when the UP status is sent the date field looks like:

Start Send SMS2 : -----
{
  recipients: [ '+48XXXXXXXX' ],
  text: '[Terminal02 - 3.166] [ Up] ',
  type: 3,
  sender: 'MTM-Kuma'
}

but when Down is sent the date field looks like this

Start Send SMS2 : -----
{
  recipients: [ '+48XXXXXXX' ],
  text: '[Terminal02 - 3.166] [ Down] PING 192.168.3.166 (192.168.3.166) 56(84) bytes of data.\n' +
    '\n' +
    '--- 192.168.3.166 ping statistics ---\n' +
    '10 packets transmitted, 0 received, 100% packet loss, time 13ms\n' +
    '\n',
  type: 3,
  sender: 'MTM-Kuma'
}

196 characters in SMS
I checked the API via POSTman and if I cut the message to 156 characters, it's ok

[PopcornPanda]

Sorry for long response time. I've to test changes for allowing long messages to be sent.
By default, PromoSMS allows sending 160 characters or 70 if special characters are used.

Fix should be ready today.