Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't see icon to remove dockge agents in "light" UI theme #646

Open
2 tasks done
bwirt opened this issue Oct 22, 2024 · 10 comments
Open
2 tasks done

Can't see icon to remove dockge agents in "light" UI theme #646

bwirt opened this issue Oct 22, 2024 · 10 comments
Labels
bug Something isn't working

Comments

@bwirt
Copy link

bwirt commented Oct 22, 2024

⚠️ Please verify that this bug has NOT been reported before.

  • I checked and didn't find similar issue

🛡️ Security Policy

Description

Maybe I'm missing something, but I can't remove a dockge agent. This causes errors to appear in the log.

image

👟 Reproduction steps

  1. Install dockge on two different machines
  2. Link them together via the UI (Home / Add Agent)
  3. Destroy the remote instance, should become unavailable
  4. Cannot delete the agent.

👀 Expected behavior

Need a trash bin icon next to the name to delete the agent.

😓 Actual Behavior

Not possible to delete agent

Dockge Version

1.4.2

💻 Operating System and Arch

Docker / Linux

🌐 Browser

Firefox

🐋 Docker Version

27.1.1

🟩 NodeJS Version

No response

📝 Relevant log output

2024-10-22T14:49:21Z [AGENT-MANAGER] ERROR: Error from the socket server: hoarder.lan:5001
@bwirt bwirt added the bug Something isn't working label Oct 22, 2024
@cyril59310
Copy link
Contributor

I was unable to reproduce the issue. Do you have any other reproduction steps to provide, or could you clarify how Docker was installed/launched?

image

I see that you're using the white theme, which is normally not available. Check if the button is just not visible because of that.

@cyril59310
Copy link
Contributor

cyril59310 commented Oct 22, 2024

After some tests, the issue does indeed come from the white theme. I recommend resetting Dockge to its default theme.

image

@bwirt
Copy link
Author

bwirt commented Oct 22, 2024

Cool... would do that if I could figure out how. Where is the light/dark setting?

image

@bwirt
Copy link
Author

bwirt commented Oct 22, 2024

I was unable to reproduce the issue. Do you have any other reproduction steps to provide, or could you clarify how Docker was installed/launched?

image

I see that you're using the white theme, which is normally not available. Check if the button is just not visible because of that.

Can confirm this is the problem. I am able to remove the agent by clicking the invisible trash can to the right.

@cyril59310
Copy link
Contributor

Cool... je le ferais si je pouvais comprendre comment. Où est le réglage clair/obscur ?

image

Normally, the setting is not available, and the dark theme is applied by default 🤨 Do you have a browser plugin that changes the theme? If not, try switching your browser to dark mode to see if it makes a difference.

@bwirt
Copy link
Author

bwirt commented Oct 23, 2024

I'm not running any browser plugin and the mode is set to automatic. Forcing the browser to dark mode doesn't change the behavior, but I did notice if I open in in "private" mode (which has a different color scheme), dockge does in fact use dark mode.

Quite strange as I have another dockge instance (one of the agents), and connecting directly brings it up in dark mode.

Running Firefox on Windows 11, latest version.

@cyril59310
Copy link
Contributor

I have never encountered this issue. I will try to conduct more in-depth tests to reproduce the problem

@bwirt
Copy link
Author

bwirt commented Oct 23, 2024

Happy to help if you need it. Quite strange. I am not sure how dockge decides light vs dark theme. If you can tell me, maybe I can assist.

@bwirt bwirt changed the title Can't remove dockge agents Can't remove dockge agents in "light" UI theme Oct 23, 2024
@bwirt bwirt changed the title Can't remove dockge agents in "light" UI theme Can't see icon to remove dockge agents in "light" UI theme Oct 23, 2024
@cyril59310
Copy link
Contributor

cyril59310 commented Oct 24, 2024

Happy to help if you need it. Quite strange. I am not sure how dockge decides light vs dark theme. If you can tell me, maybe I can assist.

Normally, in the code, Dockge is supposed to force the dark theme... It shouldn’t switch to the white theme or automatically choose a theme

@louislam
Copy link
Owner

louislam commented Oct 26, 2024

Try to clear localStorage and refresh.

https://www.leadshook.com/help/how-to-clear-local-storage-in-google-chrome-browser/

Since the core is very similar to Uptime Kuma, if you had ever hosted Uptime Kuma on the same port and the same hostname, Dockge could use Uptime Kuma's settings. Just my guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants
@louislam @bwirt @cyril59310 and others