-
Notifications
You must be signed in to change notification settings - Fork 2
Add read and write to files functionality #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update spelling error in comment
created a Files folder in App folder
…e-Facebook-WebScrapper into Anekenonso-patch-2
louicoder
reviewed
Feb 18, 2019
Owner
louicoder
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few comments and also sugestions that can even be applied online. Let me know if you need to ask anything @Anekenonso
removed the * from the function Co-Authored-By: Anekenonso <okenwanonsokenneth@gmail.com>
removed the indentation Co-Authored-By: Anekenonso <okenwanonsokenneth@gmail.com>
removed indentation Co-Authored-By: Anekenonso <okenwanonsokenneth@gmail.com>
…File & readFromTextFile
…e-Facebook-WebScrapper into Anekenonso-patch-2
louicoder
approved these changes
Feb 19, 2019
Owner
louicoder
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connect issue below by replacing id with number of your issue
connects #33
What does this PR do?