Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Locale System #346

Open
yeslayla opened this issue Jan 13, 2022 · 2 comments
Open

Implement Locale System #346

yeslayla opened this issue Jan 13, 2022 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@yeslayla
Copy link
Member

Description

We need a way to manage different languages with translations provided by the community.

I think the best way to do this would be by adding a drop down selection in the player settings that decides which json files to use (and perhaps also tying into Godot's built in locale tools). This config setting should be saved. Additionally, if a translation cannot be found, the text should default to using the English translation, as other languages are not guaranteed to have a proper translation.

@yeslayla yeslayla added enhancement New feature or request good first issue Good for newcomers labels Jan 13, 2022
@niruxx
Copy link

niruxx commented Jan 15, 2022

This sounds interesting.
I can contribute with languages that I personally know like Spanish (ES) and Dutch (NL) too
I don't think Godot's Localization options are too complex to add.

@yeslayla
Copy link
Member Author

This sounds interesting. I can contribute with languages that I personally know like Spanish (ES) and Dutch (NL) too I don't think Godot's Localization options are too complex to add.

Hi @nirux, you're welcome to give it a look! There are JSON files in the dialogue directory that would need to be swapped out based upon the locale settings. With #343, there are JSON additional language added that could be used for testing.

Pretty much need that locale configuration exposed to the options page and hooked into the JSON files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants