fixed bool[].ToFixedArray()

losttech · Sep 9, 2021 · f28befa · f28befa
1 parent 876219b
commit f28befa
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 2 deletions.
diff --git a/src/FixedArray.cs b/src/FixedArray.cs
@@ -128,8 +128,20 @@ public static unsafe IList<T> ToFixedArray<T>(this ICollection<T> collection) wh
 
             int len = collection.Count;
             var type = FixedArray<T>.GetType(len);
-            object result = Activator.CreateInstance(type);
-            var box = GCHandle.Alloc(result, GCHandleType.Pinned);
+            var result = (IList<T>)Activator.CreateInstance(type);
+
+            GCHandle box;
+            try {
+                box = GCHandle.Alloc(result, GCHandleType.Pinned);
+            } catch (ArgumentException) {
+                // workaround for bool and char not being pinnable
+                using IEnumerator<T> enumerator = collection.GetEnumerator();
+                for (int i = 0; i < len; i++) {
+                    if (!enumerator.MoveNext()) throw new ArgumentException("Bad collection enumerator");
+                    result[i] = enumerator.Current;
+                }
+                return result;
+            }
             var data = (T*)box.AddrOfPinnedObject();
 
             try {

diff --git a/tests/FixedArrayTests.cs b/tests/FixedArrayTests.cs
@@ -47,6 +47,13 @@ public void ToFixedArray() {
             Assert.Equal(netArray, array);
         }
 
+        [Fact]
+        public void ToFixedBoolArray() {
+            bool[] netArrray = new[] { false, true, true };
+            var array = netArrray.ToFixedArray();
+            Assert.Equal(netArrray, array);
+        }
+
         [Fact]
         public void ToFixedArray_TooLarge() {
             int[] netArray = new int[PowersOfTwo.Max + 1];