Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logger as dependency #1573

Merged
merged 1 commit into from
Jul 5, 2024
Merged

Add logger as dependency #1573

merged 1 commit into from
Jul 5, 2024

Conversation

wynksaiddestroy
Copy link
Contributor

To ensure compatibility with Ruby 3.4 logger needs to be added as an explicit dependency.
A deprecation warning is already shown. See the output of the RSpec step for example:
https://github.com/lostisland/faraday/actions/runs/9661172692/job/26648356492

Copy link
Member

@iMacTia iMacTia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woah I did not expect to see logger taken out!
Is Ruby gonna ship without a logger out of the box 😂?

Well, jokes aside, thank you for reporting and proposing the PR 🙂

@iMacTia iMacTia merged commit 1958cb1 into lostisland:main Jul 5, 2024
7 checks passed
@iMacTia
Copy link
Member

iMacTia commented Jul 5, 2024

Note on release: unless you need this released in a timely manner, I'd wait for #1572 to be merged and then release them together as v2.10

@wynksaiddestroy
Copy link
Contributor Author

Note on release: unless you need this released in a timely manner, I'd wait for #1572 to be merged and then release them together as v2.10

As long as it released before Ruby 3.4.0, there's no rush. Thanks for the quick merge.

@iMacTia
Copy link
Member

iMacTia commented Jul 5, 2024

I think we're good for Ruby 3.4, in the sense that we should only get the warning with that version but the code will still work. The job you linked do, in fact, run ruby 3.4.0dev and as the warning suggests logger will be removed in 3.5.0.

That said, I still want to release this as soon as possible because i) the warning is still annoying 😄 and ii) I don't want to forget about it until Ruby 3.5.0 actually arrives 🙃

@iMacTia
Copy link
Member

iMacTia commented Jul 8, 2024

Just released v2.10.0 with this fix 🙌 !
Thanks again for contributing 🙇

@wynksaiddestroy
Copy link
Contributor Author

Just released v2.10.0 with this fix 🙌 ! Thanks again for contributing 🙇

Thank you for the quick merge and the fast release ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants