-
Notifications
You must be signed in to change notification settings - Fork 980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce timeouts in Faraday's test adapter #1465
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpep
commented
Dec 6, 2022
@@ -78,8 +78,7 @@ def save_response(env, status, body, headers = nil, reason_phrase = nil, finishe | |||
# @param type [Symbol] Describes which timeout setting to get: :read, | |||
# :write, or :open. | |||
# @param options [Hash] Hash containing Symbol keys like :timeout, | |||
# :read_timeout, :write_timeout, :open_timeout, or | |||
# :timeout |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dedup :timeout
which is also on line 80
(This is a super-cool PR, @dpep, the tests run after linting passes.)
Linting complaints |
dpep
force-pushed
the
test-adapter-timeout
branch
from
December 9, 2022 16:01
f6c83bb
to
0fe2519
Compare
olleolleolle
changed the title
test adapter timeout
Enforce timeouts in Faraday's test adapter
Dec 9, 2022
olleolleolle
approved these changes
Dec 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thank you, @dpep!
good work, @dpep! : |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade faraday's test adapter to enforce connection timeouts. Inspired by the faraday-rack implementation.