Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence Multipart/Post depreciation warnings #1455

Merged
merged 2 commits into from
Nov 4, 2022

Conversation

chaffeqa
Copy link

@chaffeqa chaffeqa commented Nov 3, 2022

When starting up an app, you get:

Top level ::CompositeIO is deprecated, require 'multipart/post' and use `Multipart::Post::CompositeReadIO` instead!
Top level ::Parts is deprecated, require 'multipart/post' and use `Multipart::Post::Parts` instead!
.../faraday-0.17.5/lib/faraday/upload_io.rb:65: warning: constant ::UploadIO is deprecated
.../faraday-0.17.5/lib/faraday/upload_io.rb:66: warning: constant ::Parts is deprecated

Description

A few sentences describing the overall goals of the pull request's commits.
Link to related issues if any. (As Fixes #XXX)

Todos

List any remaining work that needs to be done, i.e:

  • Tests
  • Documentation

Additional Notes

Optional section

When starting up an app, you get:

```
Top level ::CompositeIO is deprecated, require 'multipart/post' and use `Multipart::Post::CompositeReadIO` instead!
Top level ::Parts is deprecated, require 'multipart/post' and use `Multipart::Post::Parts` instead!
.../faraday-0.17.5/lib/faraday/upload_io.rb:65: warning: constant ::UploadIO is deprecated
.../faraday-0.17.5/lib/faraday/upload_io.rb:66: warning: constant ::Parts is deprecated
```
@iMacTia
Copy link
Member

iMacTia commented Nov 3, 2022

Thank you for opening this @chaffeqa.

We currently state the following in our gemspec:

spec.add_dependency 'multipart-post', '>= 1.2', '< 3'

Do you know if multipart/post is available in all those versions or if it was introduced later?

@chaffeqa
Copy link
Author

chaffeqa commented Nov 4, 2022

Bleh great call... just refactored it. Not the most beautiful code, but gets the job done.

(Cannot wait until we can update faraday in our app!)

Copy link
Member

@iMacTia iMacTia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries! Branch 0.x is really all about supporting legacy apps, so the form doesn't matter that much, as far as it works 😄!

@iMacTia iMacTia merged commit db14de8 into lostisland:0.1x Nov 4, 2022
@chaffeqa chaffeqa deleted the patch-1 branch November 4, 2022 17:57
@ioquatix
Copy link
Contributor

ioquatix commented Nov 5, 2022

Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants