Enables and fixes all new cops #1443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olleolleolle
reviewed
Aug 8, 2022
| @@ -9,196 +9,188 @@ AllCops: | |||
| DisplayStyleGuide: true | |||
| TargetRubyVersion: 2.6 | |||
|
|
|||
| Metrics/BlockLength: | |||
| # Custom config | |||
| Gemspec/RequireMFA: # we don't know if this works with auto-deployments yet | |||
There was a problem hiding this comment.
Perhaps we should have a sign-post Issue about this rule.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enables and fixes all new cops.
Fixes #1440
Additional Notes
I've split the
.rubocop.ymlfile into sections.Next time we get the warning about new cops being released, we can simply remove the whole
New copssection, run rubocop, then copy-paste the list from the warning.This will not only keep the list in alphabetical order, but it will also prune older cops that have been auto-enabled on the last Rubocop major version