Skip to content

Commit 715e3a2

Browse files
committed
make inner classes static where possible, and remove outer class reference
1 parent 278d7bb commit 715e3a2

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

hystrix-contrib/hystrix-metrics-event-stream/src/main/java/com/netflix/hystrix/contrib/metrics/eventstream/HystrixMetricsPoller.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -509,7 +509,7 @@ public Long call() {
509509
}
510510
}
511511

512-
private class MetricsPollerThreadFactory implements ThreadFactory {
512+
private static class MetricsPollerThreadFactory implements ThreadFactory {
513513
private static final String MetricsThreadName = "HystrixMetricPoller";
514514

515515
private final ThreadFactory defaultFactory = Executors.defaultThreadFactory();

hystrix-core/src/main/java/com/netflix/hystrix/util/HystrixRollingNumber.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -504,7 +504,7 @@ LongMaxUpdater getMaxUpdater(HystrixRollingNumberEvent type) {
504504
* <p>
505505
* benjchristensen => This implementation was chosen based on performance testing I did and documented at: http://benjchristensen.com/2011/10/08/atomiccirculararray/
506506
*/
507-
/* package */class BucketCircularArray implements Iterable<Bucket> {
507+
/* package */static class BucketCircularArray implements Iterable<Bucket> {
508508
private final AtomicReference<ListState> state;
509509
private final int dataLength; // we don't resize, we always stay the same, so remember this
510510
private final int numBuckets;

hystrix-core/src/main/java/com/netflix/hystrix/util/HystrixRollingPercentile.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -453,7 +453,7 @@ private int computePercentile(double percent) {
453453
* <p>
454454
* benjchristensen => This implementation was chosen based on performance testing I did and documented at: http://benjchristensen.com/2011/10/08/atomiccirculararray/
455455
*/
456-
/* package for testing */ class BucketCircularArray implements Iterable<Bucket> {
456+
/* package for testing */ static class BucketCircularArray implements Iterable<Bucket> {
457457
private final AtomicReference<ListState> state;
458458
private final int dataLength; // we don't resize, we always stay the same, so remember this
459459
private final int numBuckets;

hystrix-core/src/main/java/com/netflix/hystrix/util/HystrixTimer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ public void run() {
107107
return new TimerReference(listener, f);
108108
}
109109

110-
private class TimerReference extends SoftReference<TimerListener> {
110+
private static class TimerReference extends SoftReference<TimerListener> {
111111

112112
private final ScheduledFuture<?> f;
113113

0 commit comments

Comments
 (0)