Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this a bug? #79

Closed
mjstudio opened this issue Oct 12, 2020 · 1 comment
Closed

Is this a bug? #79

mjstudio opened this issue Oct 12, 2020 · 1 comment

Comments

@mjstudio
Copy link

mjstudio commented Oct 12, 2020

I am wondering if
check_dnfreq(s2ctx, D, &txjob->rx2freq, &txjob->dnchnl);
should be check_dnfreq(s2ctx, D, &txjob->rx2freq, &txjob->dnchnl2);
in the following function?

void handle_dnmsg (s2ctx_t* s2ctx, ujdec_t* D) {
... ...
case J_Freq:
case J_RX1Freq: {
check_dnfreq(s2ctx, D, &txjob->freq, &txjob->dnchnl);
flags |= 0x0200;
break;
}
case J_RX2DR: {
check_dr(s2ctx, D, &txjob->rx2dr);
flags |= 0x0400;
break;
}
case J_RX2Freq: {
check_dnfreq(s2ctx, D, &txjob->rx2freq, &txjob->dnchnl);
flags |= 0x0800;
break;
}
...
}

@ogimenez-smtc
Copy link

Hi,

You are right it seems to be an issue, we will confirm it and correct it if required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants