Update to TypeScript 4.1 #421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a breaking change as of TS 4.x: microsoft/TypeScript#39963 More context: microsoft/TypeScript#25710 (comment)
Contributor
Test Results 14 files 14 suites 1m 22s ⏱️ Results for commit 1604c6e. |
jkaster
approved these changes
Dec 21, 2020
jkaster
left a comment
jkaster
left a comment
There was a problem hiding this comment.
Nice! Great to finally get TS updated
Comment on lines
+405
to
+406
| const swaggerFile = `${config.rootPath}spec/Looker.4.0.json` | ||
| const apiFile = `${config.rootPath}spec/Looker.4.0.oas.json` |
There was a problem hiding this comment.
testUtils now has a rootFile() function we can use to fix this up in a future PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.