Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Routes read from Myth's config instead of App's config (ie: will not read App AuthController) #9

Closed
fefo-p opened this issue Aug 23, 2018 · 6 comments

Comments

@fefo-p
Copy link
Contributor

fefo-p commented Aug 23, 2018

Although routes are correctly set in App\Config\Routes.php, somehow routes are being loaded from Myth\Auth\Config\Routes.php.

I got to notice this while trying to only allow access to Admin for registering new users.

screen shot 2018-08-23 at 15 07 27
myth_routes
app_routes

@lonnieezell
Copy link
Owner

I'll try to look into that one tonight, as it sounds like a CodeIgniter issue itself. It's been a bit since I worked on that code, but I'm thinking it auto-discovers other routes after parsing the existing ones and I need to adjust how it merges the two...

@fefo-p
Copy link
Contributor Author

fefo-p commented Aug 23, 2018

Ok, I'll let you know if I find something myself. So far it seems there's some namespace problems.
It also happens with Config and Controllers

@lonnieezell
Copy link
Owner

I will say that you're brave for attempting to use this package currently. :) But I do appreciate someone else actually helping point out bugs, since I haven't managed to put in enough time to get it wrapped up, yet. Most of the testing I had done on it was on the authentication portions, not the groups.

Though, if you were able to start submitting pull requests for these I could get them incorporated faster. :)

@fefo-p
Copy link
Contributor Author

fefo-p commented Aug 23, 2018

Sounds good, but I still have to figure out how all of the "Diff world" works.
I've never used pull requests as I've always worked locally. But, I will figure it out as I understand it's much easier that way

@lonnieezell
Copy link
Owner

Just pushed some code in CodeIgniter repo that should fix this. Give it a whirl and let me know, please.

@fefo-p
Copy link
Contributor Author

fefo-p commented Aug 25, 2018

Great. This has been fixed alright!
screen shot 2018-08-25 at 07 37 33

@fefo-p fefo-p closed this as completed Aug 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants