-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add longhorn/types #404
Conversation
This pull request is now in conflict. Could you fix it @FrankYang0529? 🙏 |
98f88dd
to
80f48ff
Compare
This pull request is now in conflict. Could you fix it @FrankYang0529? 🙏 |
Signed-off-by: PoAn Yang <poan.yang@suse.com>
454cdd1
to
29531fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@FrankYang0529 ready to merge?
Hi @derekbit, may we merge longhorn/longhorn-engine#1015 first? So I can remove |
Sure! Merged. |
Signed-off-by: PoAn Yang <poan.yang@suse.com>
Signed-off-by: PoAn Yang <poan.yang@suse.com>
Hi @derekbit, this one is ready. Thank you. |
@FrankYang0529 Do you know who uses the gernerated python codes? |
longhorn-engine integration test uses it. I moved related files to longhorn-engine folder, so we don't need to copy it from longhorn-instance-manager. https://github.com/longhorn/longhorn-engine/tree/master/integration |
Got it. Thank you. |
We have a script working for it. https://github.com/longhorn/longhorn-engine/blob/master/scripts/sync-grpc-py |
Cool. I missed the python script. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Which issue(s) this PR fixes:
Issue longhorn/longhorn#6744, longhorn/longhorn#5752
What this PR does / why we need it:
Special notes for your reviewer:
Additional documentation or context