Skip to content

Commit c842374

Browse files
committed
Change a format of exception message
1 parent 3a1e681 commit c842374

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

src/main/java/com/longcoding/moon/exceptions/ExceptionAdvice.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ public ResponseEntity generalException(GeneralException e, HttpServletRequest re
8989
ExceptionType exceptionType = e.getExceptionType();
9090
setHttpResponseErrorCode(request, exceptionType.getCode());
9191
String message = messageManager.getProperty(exceptionType.getCode());
92-
if (Strings.isNotEmpty(e.getMessage())) message += e.getMessage();
92+
if (Strings.isNotEmpty(e.getMessage())) message = String.format("%s %s", message, e.getMessage());
9393
CommonResponseEntity response = CommonResponseEntity.generateException(e.getExceptionType().getCode(), message);
9494
return HttpHelper.newResponseEntityWithId(e.getExceptionType().getHttpStatus(), response);
9595
}

src/main/java/com/longcoding/moon/interceptors/AbstractBaseInterceptor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ protected void generateException(ExceptionType exceptionType) {
5252

5353
protected void generateException(ExceptionType exceptionType, String message) {
5454
logger.error("error occur in [{}]", getClass().getName());
55-
throw new GeneralException(exceptionType);
55+
throw new GeneralException(exceptionType, message);
5656
}
5757

5858
/**

src/main/java/com/longcoding/moon/interceptors/impl/HeaderAndQueryValidationInterceptor.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,15 +59,15 @@ public boolean preHandler(HttpServletRequest request, HttpServletResponse respon
5959
if (requestHeaders.containsKey(header) || optionHeaders.contains(header)) {
6060
proxyRequestHeaders.put(header, requestHeaders.get(header));
6161
} else if (headers.get(header).equals(true)) {
62-
generateException(ExceptionType.E_1007_INVALID_OR_MISSING_ARGUMENT, "required header is missing.");
62+
generateException(ExceptionType.E_1007_INVALID_OR_MISSING_ARGUMENT, String.format("- %s", header));
6363
}
6464
}
6565

6666
for (String queryParam : queryParams.keySet()) {
6767
if (requestQueryParams.containsKey(queryParam)) {
6868
proxyRequestQueryParams.put(queryParam, requestQueryParams.get(queryParam));
6969
} else if (queryParams.get(queryParam).equals(true)) {
70-
generateException(ExceptionType.E_1007_INVALID_OR_MISSING_ARGUMENT, "required query parameter is missing.");
70+
generateException(ExceptionType.E_1007_INVALID_OR_MISSING_ARGUMENT, String.format("- %s", queryParam));
7171
}
7272
}
7373
} else if (RoutingType.SKIP_API_TRANSFORM == requestInfo.getRoutingType()) {

0 commit comments

Comments
 (0)