Merge pull request #191 from Jeffzholy/improvements/chapter-7-Set

improvements: isSubsetOf function of Set
loiane · May 12, 2022 · 8a39b5c · 8a39b5c
2 parents c0bd451 + 91887bc
commit 8a39b5c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 26 deletions.
diff --git a/src/js/data-structures/set.js b/src/js/data-structures/set.js
@@ -63,18 +63,8 @@ export default class Set {
   }
 
   isSubsetOf(otherSet) {
-    if (this.size() > otherSet.size()) {
-      return false;
-    }
-    let isSubset = true;
-    this.values().every(value => {
-      if (!otherSet.has(value)) {
-        isSubset = false;
-        return false;
-      }
-      return true;
-    });
-    return isSubset;
+    const values = this.values();
+    return values.every((value) => otherSet.has(value));
   }
 
   isEmpty() {

diff --git a/src/ts/data-structures/set.ts b/src/ts/data-structures/set.ts
@@ -75,20 +75,8 @@ export default class Set<T> {
   }
 
   isSubsetOf(otherSet: Set<T>) {
-    if (this.size() > otherSet.size()) {
-      return false;
-    }
-
-    let isSubset = true;
-    this.values().every(value => {
-      if (!otherSet.has(value)) {
-        isSubset = false;
-        return false;
-      }
-      return true;
-    });
-
-    return isSubset;
+    const values = this.values();
+    return values.every((value) => otherSet.has(value));
   }
 
   isEmpty() {