Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added feature to template header #56

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

derHeinz
Copy link

Add ability to "template" header values / to use dynamic values on header values.

Addresses those isseus:
#41
#42

@cla-checker-service
Copy link

cla-checker-service bot commented Jul 14, 2023

💚 CLA has been signed

@derHeinz
Copy link
Author

I cannot find the reason for the failing build, as my changes are to output side of and failure occures on input side. Any ideas on that?

singed the contributor agreement.

@0akarma
Copy link

0akarma commented Jul 29, 2023

I have built the plugin locally and it works fine to me except a field which type is array and it casts it to the string type.
The error looks like some ci error because it works find in 7.x and 8.x.

@derHeinz
Copy link
Author

derHeinz commented Aug 1, 2023

Thanks for testing @0akarma.
How can this PR be merged soon?

@derHeinz
Copy link
Author

derHeinz commented Aug 1, 2023

@0akarma: guess you tested to add an array type of field to the headers, like so?

...
output {
  rabbitmq {
    ...
    message_properties => {
        headers => {
			MyArray => "%{my-array-containing-value}"
...

@0akarma
Copy link

0akarma commented Aug 7, 2023

@0akarma: guess you tested to add an array type of field to the headers, like so?

...
output {
  rabbitmq {
    ...
    message_properties => {
        headers => {
			MyArray => "%{my-array-containing-value}"
...

Yes, it can not format the array field timelimit as well which looks like this

"timelimit" => [
    [0] 18000,
    [1] 7200
]

Here are my nested headers.

"headers" => {
          "task" => "%{[@metadata][rabbitmq_headers][task]}"
          "id" => "%{[@metadata][rabbitmq_headers][id]}"
          "rootid" => "%{[@metadata][rabbitmq_headers][root_id]}"
          "parent_id" => "%{[@metadata][rabbitmq_headers][parent_id]}"
          "ignore_result" => "%{[@metadata][rabbitmq_headers][ignore_result]}"
          "retries" => "%{[@metadata][rabbitmq_headers][retries]}"
          "timelimit" => "%{[@metadata][rabbitmq_headers][timelimit]}"
}

@0akarma
Copy link

0akarma commented Aug 7, 2023

Thanks for testing @0akarma. How can this PR be merged soon?

I will have a try when i finished the test on the back-pressure feature :)

@derHeinz
Copy link
Author

@0akarma have you already had the time to check this one?

@derHeinz
Copy link
Author

derHeinz commented May 6, 2024

Any progress on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants