Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further Load Balancer improvements. #18

Open
mashhurs opened this issue Nov 3, 2023 · 0 comments
Open

Further Load Balancer improvements. #18

mashhurs opened this issue Nov 3, 2023 · 0 comments
Assignees

Comments

@mashhurs
Copy link
Contributor

mashhurs commented Nov 3, 2023

Description

Load balancer

Currently we have a minimal promise pattern that guarantees the balance with both cool off and back off periods. Backoff period now covers general broad case. If LS has multiple hosts and it has only single host failure, back off might not be useful. From current point of view we found that it is not an super urgent since we have milliseconds interval sleeps but in the future we may improve this area.

Test cases

With LB implementation, we simply covered the logic unit tests cases but some (load_balancer_spec.rb) of them are tightly coupled or some (in logstash_output_spec.rb) tests can be improved.

@mashhurs mashhurs self-assigned this Nov 3, 2023
@mashhurs mashhurs changed the title Improve Rspec unit tests. Further Load Balancer improvements. Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant