Fix: resolve crash when commands_map is set #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kares
changed the title
yaauie
reviewed
Apr 6, 2021
Co-authored-by: Ry Biesemeyer <yaauie@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plugin changes here were not compatible with Redis 4 (due
redis.clientusage).Likely missed while upgrading from Redis 3.x - probably due mocking the redis interface completely in tests.
Setting
commands_map => ...for the plugin never really worked (see #80 for details).The updated interface is based on
Redis4.0.1.Specs look a bit ugly but should be less "mocky" than before, they will likely need more 🍼.
resolves #80