Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: logstash-plugins/logstash-input-http_poller
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: logstash-plugins/logstash-input-http_poller
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: plugin-api-v1
Choose a head ref
  • 1 commit
  • 3 files changed
  • 1 contributor

Commits on Sep 20, 2016

  1. Use rufus scheduler to support more flexible scheduling options. (#60) 

    It supports four different types of scheduling - cron, every, in and at.
"every" option (e.g. every 5 minutes) offers the same functionality
as existing Stud/interval scheduling. Therefore, 'interval' config
option is deprecated.

1) bumped to 2.1.0

2) Made the following interface changes to the plugin configs:
 + deprecated "interval" option
 + added "schedule" option. e.g schedule => { every => "2m"}

3) If both are specified, raise ConfigurationError.

4) Use existing Stud library if interval option is specified. Use
rufus-scheduler if schedule option is specified.

5) The first invoke of "every" schedule type is configured to run
immediately to match the semantic of interval option.

6) The first invoke of "every" schedule type in rufus-scheduler(v3.0.9)
sometimes does not run immediately, even if :first => :now is specified.
i.e sometimes the first run is invoked immediately after schedule is
started, but sometimes only after the first interval is elasped. The
issue is no longer reproducible in current version (v3.2.2). However,
I can't upgrade to v3.2.2 immediately since other logstash plugins
are using old version. So, I added a workaround that works for both
versions.
    @hummingV
    hummingV authored and Suyog Rao committed Sep 20, 2016
    Configuration menu
    Copy the full SHA
    8af623b View commit details
    Browse the repository at this point in the history
Loading