Add reponse_body to be able to provide a custom body (issue 117) #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucabelluccini
changed the title
andsel
requested changes
May 24, 2021
| response.headers().set(HttpHeaderNames.CONTENT_LENGTH, payload.readableBytes()); | ||
| response.headers().set(HttpHeaderNames.CONTENT_TYPE, "text/plain"); |
There was a problem hiding this comment.
Instead of removing the response's content-type we could also provide an customization option for it.
Close to response_body it could be also defined a new response_content_type which by default contains text/plain but in case the user could also modify it.
In particular on registration phase, if the user customized the response body then it should be also forced to explicitly define also a response's content-type
There was a problem hiding this comment.
Yep it's a nice idea. I hope I'll have a chance to resume working on this 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I've tried to implement the missing feature as mentioned on #117
I am still not sure how to handle the
content-typeheader as it seems we're re-using the one sent in the request, if any.FYI @jsvd