Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting password without username should raise an error #88

Open
jsvd opened this issue May 11, 2018 · 1 comment
Open

Setting password without username should raise an error #88

jsvd opened this issue May 11, 2018 · 1 comment
Labels
bug good first issue

Comments

@jsvd
Copy link
Member

jsvd commented May 11, 2018

Starting the plugin with input { http { password => 'hello'} } will not enable auth and also raise no warning or error that both username and password are needed to setup basic auth.

replaces #63
@jsvd jsvd added the bug label May 11, 2018
@jsvd jsvd mentioned this issue May 11, 2018
Closed
@jsvd jsvd added the hacktoberfest "Everyone is welcome, Quantity is fun, quality is key, Short term actions, long term impact" label Oct 17, 2018
@knaggit
Copy link

knaggit commented Nov 30, 2018

I just stumble over this issue here and would appreciate change this behaviour. It even would be nice for things like webhooks which just require a secret (regarding to GitHub webhooks), to configure just a password. Above that I totally agree with the bug description.

@jsvd jsvd added good first issue and removed hacktoberfest "Everyone is welcome, Quantity is fun, quality is key, Short term actions, long term impact" labels Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jsvd @knaggit