Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should this be moved to a codec? #22

Open
andrewvc opened this issue Dec 18, 2015 · 4 comments
Open

Should this be moved to a codec? #22

andrewvc opened this issue Dec 18, 2015 · 4 comments

Comments

@andrewvc
Copy link

It's kind of crazy, but we don't have an XML codec! Should this code be moved to a codec, and the filter deprecated?

@colinsurprenant
Copy link
Contributor

I agree that we should have an xml codec, but many users still need it as a filter, sometimes the xml is embedded within the raw data, same for json, we have both the codec and the filter. Now, the real question is if we should be able to run codecs as a filters, with something like a filter-codec plugin, I believe this has been suggested before and in particular I think @jsvd proposed a PR for this?

This would DRY up the double codec/filter implementations...

@guyboertje
Copy link

I think people may need a multiline codec in their input.

This may be solved by my input refactor (poc pending in xmas period) that will enable codec chaining in the input. But then a xml codec is needed for the chain.

@andrewvc
Copy link
Author

It sounds like the right action plan would be:

  1. Make a codec
  2. Determine if a codec-filter makes sense. I'm personally +1 on the idea. Much more DRY/sane.

@colinsurprenant
Copy link
Contributor

created issue elastic/logstash#4383 to keep track of the filter-codec idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants