replicate workflow ACL into new version

Author: car031

logicaldoc-gui/src/main/java/com/logicaldoc/gui/common/client/data/WorkflowAclDS.java

@@ -24,6 +24,7 @@ public WorkflowAclDS(long id) {
 
 		setFields(entityId, entity, read, write, type);
 		setClientOnly(true);
+
 		setDataURL("data/workflowacl.xml?workflowId=" + id + "&locale=" + I18N.getLocale());
 	}
 }

logicaldoc-gui/src/main/java/com/logicaldoc/gui/frontend/client/services/WorkflowService.java

@@ -89,6 +89,15 @@ public GUIWorkflow getCompletionDiagram(String workflowName, Integer version, St
 	 */
 	public GUIWorkflow save(GUIWorkflow workflow) throws ServerException;
 
+	/**
+	 * Saves just the ACL of a workflow
+	 * 
+	 * @param workflow the workflow to save the ACL
+	 * 
+	 * @throws ServerException an error happened in the server application
+	 */
+	public void saveACL(GUIWorkflow workflow) throws ServerException;
+	
 	/**
 	 * Deploys a given workflow
 	 * 

logicaldoc-gui/src/main/java/com/logicaldoc/gui/frontend/client/services/WorkflowServiceAsync.java

@@ -17,6 +17,8 @@ public interface WorkflowServiceAsync {
 
 	void save(GUIWorkflow workflow, AsyncCallback<GUIWorkflow> callback);
 
+	void saveACL(GUIWorkflow workflow, AsyncCallback<Void> callback);
+
 	void deleteTrigger(long id, AsyncCallback<Void> callback);
 
 	void saveTrigger(String folderId, String workflowId, String templateId, String events,

logicaldoc-gui/src/main/java/com/logicaldoc/gui/frontend/client/workflow/designer/WorkflowSecurity.java

@@ -3,15 +3,17 @@
 import java.util.ArrayList;
 import java.util.List;
 
+import com.google.gwt.user.client.rpc.AsyncCallback;
 import com.logicaldoc.gui.common.client.beans.GUIAccessControlEntry;
 import com.logicaldoc.gui.common.client.beans.GUIWorkflow;
 import com.logicaldoc.gui.common.client.data.WorkflowAclDS;
 import com.logicaldoc.gui.common.client.i18n.I18N;
+import com.logicaldoc.gui.common.client.log.GuiLog;
 import com.logicaldoc.gui.common.client.util.GridUtil;
 import com.logicaldoc.gui.common.client.util.ItemFactory;
 import com.logicaldoc.gui.common.client.util.LD;
 import com.logicaldoc.gui.common.client.widgets.grid.UserListGridField;
-import com.smartgwt.client.data.Record;
+import com.logicaldoc.gui.frontend.client.services.WorkflowService;
 import com.smartgwt.client.types.HeaderControls;
 import com.smartgwt.client.types.ListGridFieldType;
 import com.smartgwt.client.types.SelectionStyle;
@@ -107,6 +109,7 @@ void refresh(GUIWorkflow workflow) {
 		list.setHeight100();
 		list.setMinHeight(200);
 		list.setMinWidth(300);
+
 		dataSource = new WorkflowAclDS(Long.parseLong(workflow.getId()));
 		list.setDataSource(dataSource);
 
@@ -231,22 +234,17 @@ private void addGroupSelector(HLayout buttons) {
 	 * @return the list of ACEs
 	 */
 	public List<GUIAccessControlEntry> getACL() {
-		int totalRecords = list.getRecordList().getLength();
 		List<GUIAccessControlEntry> acl = new ArrayList<>();
 
-		for (int i = 0; i < totalRecords; i++) {
-			Record rec = list.getRecordList().get(i);
-			if (Boolean.FALSE.equals(rec.getAttributeAsBoolean("read")))
-				continue;
-
-			GUIAccessControlEntry right = new GUIAccessControlEntry();
-
-			right.setName(rec.getAttributeAsString(ENTITY));
-			right.setEntityId(Long.parseLong(rec.getAttribute(ENTITY_ID)));
-			right.setWrite("true".equals(rec.getAttributeAsString(WRITE)));
-
-			acl.add(right);
-		}
+		if (list.getRecords() != null)
+			for (ListGridRecord rec : list.getRecords()) {
+				GUIAccessControlEntry right = new GUIAccessControlEntry();
+				right.setName(rec.getAttributeAsString(ENTITY));
+				right.setEntityId(Long.parseLong(rec.getAttribute(ENTITY_ID)));
+				right.setWrite("true".equals(rec.getAttributeAsString(WRITE)));
+				right.setRead("true".equals(rec.getAttributeAsString("read")));
+				acl.add(right);
+			}
 
 		return acl;
 	}
@@ -268,8 +266,7 @@ private Menu setupContextMenu() {
 
 		MenuItem deleteItem = new MenuItem();
 		deleteItem.setTitle(I18N.message("ddelete"));
-		deleteItem.addClickHandler(event ->
-				onDelete());
+		deleteItem.addClickHandler(event -> onDelete());
 
 		contextMenu.setItems(deleteItem);
 		return contextMenu;
@@ -288,6 +285,16 @@ private void onDelete() {
 
 	public void onSave() {
 		workflow.setAccessControlList(getACL());
-		destroy();
+		WorkflowService.Instance.get().saveACL(workflow, new AsyncCallback<Void>() {
+			@Override
+			public void onFailure(Throwable caught) {
+				GuiLog.serverError(caught);
+			}
+
+			@Override
+			public void onSuccess(Void arg0) {
+				destroy();
+			}
+		});
 	}
 }