Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the Api Tokens to local storage instead of storing them in data.json #902

Open
babeal opened this issue Dec 7, 2024 · 0 comments
Open

Comments

@babeal
Copy link

babeal commented Dec 7, 2024

Is your feature request related to a problem? Please describe.

While encrypting the tokens is a step in the right direction, I still don't want credentials or derivatives of credentials stored on disk in the same file as the plugins general settings to be synced to cloud services.

Describe the solution you'd like

Take a look at https://github.com/gavvvr/obsidian-imgur-plugin/blob/main/src/uploader/imgUploaderFactory.ts for a reasonable solution. The obsidian imgur plugin uses local storage to store the key for imagur after authentication and would be a good place for the api tokens. This way the key is not on disk, doesn't get backed up to obsidian data service, git, or icloud, and allows the sharing of the rest of the configuration.

Describe alternatives you've considered

Adding the data.json to .gitignore but then I have to reconfigure this plugin for every client I have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

2 participants