Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some ideas for processors/grepper.py #127

Open
4 tasks
rgayon opened this issue Jan 4, 2019 · 0 comments
Open
4 tasks

Some ideas for processors/grepper.py #127

rgayon opened this issue Jan 4, 2019 · 0 comments
Assignees
@pstirparo
Labels
enhancement

Comments

@rgayon
Copy link
Contributor

rgayon commented Jan 4, 2019

  • Delete the temporary directory in cleanup()
  • Doctring says """"Execute the grep command""" though that's not happening =)
  • _final_output is never used? Should it be initialized to '' so you can start appending to it right away?
  • Probably don't need to filter(None, found) as you already check [item for item in found if item]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pstirparo pstirparo

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tomchop @pstirparo @rgayon