Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to download individual metadata? #2019

Closed
emmahodcroft opened this issue May 26, 2024 · 11 comments · Fixed by #3003
Closed

How to download individual metadata? #2019

emmahodcroft opened this issue May 26, 2024 · 11 comments · Fixed by #3003
Assignees
Labels
feature Feature proposal website Tasks related to the web application

Comments

@emmahodcroft
Copy link
Member

I was tying to check our field (column) names and so went to download the info for just one sequence. I went to Ebola Sudan (though don't think this matters) and clicked on the first sequence in the list, bringing it into the 'pop up view'.

However, I was surprised when I clicked the 'download' icon in the top-right and was not given any choice of what to download - it just downloaded a Fasta - when what I actually want is the metadata!

I'd suggest we add possibly two links (one FASTA, one metadata) or some other kind of selector (perhaps also offering GB file that has both?) - it's odd to me one can't just download metadata for one sequence!

@emmahodcroft emmahodcroft added the feature Feature proposal label May 26, 2024
@theosanderson
Copy link
Member

To clarify would this be in TSV format with one row, or something else?

@anna-parker
Copy link
Contributor

I also noticed this - to only download the metadata of one sequence at the moment you need to add the specific accession of that sequence to the search filter and then you can use the download options box to only download the metadata

@chaoran-chen chaoran-chen added this to the MVP (nice to have) milestone Jul 4, 2024
@chaoran-chen chaoran-chen added the website Tasks related to the web application label Jul 4, 2024
@corneliusroemer
Copy link
Contributor

@fhennig
Copy link
Contributor

fhennig commented Oct 2, 2024

@emmahodcroft what to you mean with GB file?

I'd suggest that when the download button is clicked there is a dropdown/pop-up menu with multiple options (metadata, Fasta, GB (?))

@theosanderson
Copy link
Member

I guess Emma means a GenBank file. I would defer that to a future issue for now as it will be quite a bit more involved.

@fhennig
Copy link
Contributor

fhennig commented Oct 16, 2024

In the full sequence view (i.e. https://pathoplexus.org/seq/PP_000PHAJ.2 ) the Download FASTA button is not rendered if the sequence is restricted. Should downloading metadata still be allowed or not? For now (because it's the easiest) I just have it display nothing if the sequence is restricted, and show both options if it isn't.

Also I think in the regular popover details, the button doesn't have this behaviour. In the code, the two buttons are implemented differently.

@theosanderson
Copy link
Member

I wasn't aware that we don't show the button if the sequence is restricted! iMO we should change that – especially as we show the sequence anyway.

@fhennig
Copy link
Contributor

fhennig commented Oct 16, 2024

Can you give me a bit of domain knowledge about this, what does it mean that a sequence is restricted?

@theosanderson
Copy link
Member

The best nomenclature is probably a bit more nuanced than calling the sequence just "restricted" - although it's easy to slip into doing that. All sequences released on Pathoplexus are publicly available. But some researchers want to maintain an exclusive ability to publish results analysing their sequences for some time to ensure they are not "scooped". To allow early sharing of sequences Pathoplexus allows submitters to choose between "Open" and "Restricted" data use terms on submission. The "Restricted" case, if chosen, applies for up to a year, then sequences move to the Open Data Use Terms. Under the Restricted Data Use Terms the sequence is available, but only under the Restricted Use Terms which prevent others from publishing analysis focusing on this data.

From a dev point of view the goals are to make very clear when sequences are only available under restricted terms, but not to prevent their download.

@fhennig
Copy link
Contributor

fhennig commented Oct 16, 2024

Got it, thanks for clarifying!

@theosanderson
Copy link
Member

(For others reading - as discussed in the more detailed review - on reviewing the code this visibility-of-download-button thing isn't about restricted sequences but about revocations)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature proposal website Tasks related to the web application
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

6 participants