Skip to content

Enable the specification of "platform" when configuring localstack container #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 30, 2021

Conversation

nofranks
Copy link
Contributor

This PR enables the specification of the platform argument when configuring a localstack container using the @LocalstackDockerProperties annotation.

The prinicpal reason for this is to enable such tests to be written and executed on apple silicon. Presently, the command to run the container returns a container id prefixed with a warning message, which prevents the test from being able to detect when the container is ready. Including the platform with the value "linux_amd64" runs the image as an emulation and results in the expected container id being returned

Copy link
Member

@whummer whummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @nofranks ! 👍 Just a tiny nitpick comments..

@whummer
Copy link
Member

whummer commented Mar 30, 2021

Great, thanks for the quick turnaround!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants