🔆/🔅 Enabled dark mode in Docsy theme👨🏼🦯 #1759
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flash Bang Out!
|
⚡️ Deploying PR Preview... |
HarshCasper
reviewed
Jun 16, 2025
There was a problem hiding this comment.
Hi — Thanks for working on this! I created a preview environment to make it easy to visualize the changes.
IMHO, this requires more changes for several reasons:
- The dark/light mode toggle is not visible anywhere, so users can't switch between modes
- Text in the right sidebar has become too dark, creating poor contrast and accessibility problems
- Some sections also appear to have inconsistent theming
Due to these issues, I'm not inclined to merge this at the moment. We're also launching v2 of our documentation engine in a few weeks, which will move us from Hugo to Astro's Starlight with built-in dark mode support, making this a more seamless solution.
I understand this isn't the desired outcome, but I want to thank you for your contribution and appreciate your work! 🙇 🙌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #535
Please maintainer. it's 4:35am and I should have been in bed hours ago. My eyes already hurt enough 🙏
Relevant Documentation