Skip to content

Commit 847547f

Browse files
committed
fix adding --s3-endpoint-url=... only to selected CF commands
1 parent cdd666a commit 847547f

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

bin/awslocal

+4-2
Original file line numberDiff line numberDiff line change
@@ -122,9 +122,11 @@ def prepare_cmd_args():
122122
cmd_args = sys.argv
123123
if endpoint:
124124
cmd_args.insert(1, '--endpoint-url=%s' % endpoint)
125-
cmd_args.insert(2, '--s3-endpoint-url=%s' % endpoint)
126125
if 'https' in endpoint:
127-
cmd_args.insert(3, '--no-verify-ssl')
126+
cmd_args.insert(2, '--no-verify-ssl')
127+
# TODO: check the logic below and make it more resilient
128+
if 'cloudformation' in cmd_args and any(cmd in cmd_args for cmd in ['deploy', 'package']):
129+
cmd_args.insert(2, '--s3-endpoint-url=%s' % endpoint)
128130
return list(cmd_args)
129131

130132

setup.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
setup(
88
name='awscli-local',
9-
version='0.10',
9+
version='0.11',
1010
description='Thin wrapper around the "aws" command line interface for use with LocalStack',
1111
author='Waldemar Hummer',
1212
author_email='waldemar.hummer@gmail.com',

0 commit comments

Comments
 (0)