Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ refactor: Refactor services code style #5180

Merged
merged 3 commits into from
Dec 26, 2024
Merged

♻️ refactor: Refactor services code style #5180

merged 3 commits into from
Dec 26, 2024

Conversation

canisminor1990
Copy link
Member

💻 变更类型 | Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 👷 build
  • ⚡️ perf
  • 📝 docs
  • 🔨 chore

🔀 变更说明 | Description of Change

📝 补充信息 | Additional Information

@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Dec 25, 2024
@vercel Vercel
Copy link

vercel bot commented Dec 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lobe-chat-database ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 26, 2024 2:37am
lobe-chat-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 26, 2024 2:37am

@lobehubbot
Copy link
Member

👍 @canisminor1990

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
非常感谢您提出拉取请求并为我们的社区做出贡献，请确保您已经遵循了我们的贡献指南，我们会尽快审查它。
如果您遇到任何问题，请随时与我们联系。

@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
lobe-chat-preview 🔄 Building (Inspect) Visit Preview Dec 25, 2024 2:05pm

@codecov Codecov
Copy link

codecov bot commented Dec 25, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 51.32159% with 221 lines in your changes missing coverage. Please review.

Project coverage is 92.15%. Comparing base (9684c98) to head (87b9d8b).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/services/session/server.ts 0.00% 50 Missing ⚠️
src/services/message/server.ts 2.00% 49 Missing ⚠️
src/services/topic/server.ts 4.00% 24 Missing ⚠️
src/services/agent.ts 28.00% 18 Missing ⚠️
src/services/plugin/server.ts 6.66% 14 Missing ⚠️
src/services/rag.ts 33.33% 12 Missing ⚠️
src/services/file/server.ts 50.00% 10 Missing ⚠️
src/services/thread/server.ts 0.00% 10 Missing ⚠️
src/services/user/server.ts 0.00% 9 Missing ⚠️
src/services/message/client.ts 90.38% 5 Missing ⚠️
... and 8 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5180      +/-   ##
==========================================
- Coverage   92.32%   92.15%   -0.18%     
==========================================
  Files         568      568              
  Lines       43204    43119      -85     
  Branches     3978     3989      +11     
==========================================
- Hits        39887    39735     -152     
- Misses       3317     3384      +67
Flag Coverage Δ
app 92.15% <51.32%> (-0.18%) ⬇️
server 97.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

arvinxx
arvinxx requested changes Dec 25, 2024
View reviewed changes
src/services/ollama.ts Outdated Show resolved Hide resolved
@arvinxx arvinxx changed the title 💄 style: Refactor services code style ♻️ refactor: Refactor services code style Dec 25, 2024
@canisminor1990 canisminor1990 merged commit e98ece8 into main Dec 26, 2024
10 of 11 checks passed
@canisminor1990 canisminor1990 deleted the style/services-code-style branch December 26, 2024 03:03
@lobehubbot
Copy link
Member

❤️ Great PR @canisminor1990 ❤️

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.
项目的成长离不开用户反馈和贡献，感谢您的贡献! 如果您对 LobeHub 开发者社区感兴趣，请加入我们的 discord，然后私信 @arvinxx 或 @canisminor1990。他们会邀请您加入我们的私密开发者频道。我们将会讨论关于 Lobe Chat 的开发，分享和讨论全球范围内的 AI 消息。

github-actions bot pushed a commit that referenced this pull request Dec 26, 2024
@semantic-release-bot
🔖 chore(release): v1.40.0 [skip ci]
0602aaf 
## [Version&nbsp;1.40.0](v1.39.3...v1.40.0)
<sup>Released on **2024-12-26**</sup>

#### ♻ Code Refactoring

- **misc**: Refactor services code style.

#### ✨ Features

- **misc**: Add changelog modal.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### Code refactoring

* **misc**: Refactor services code style, closes [#5180](#5180) ([e98ece8](e98ece8))

#### What's improved

* **misc**: Add changelog modal, closes [#4800](#4800) ([df3ac87](df3ac87))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@lobehubbot
Copy link
Member

🎉 This PR is included in version 1.40.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

gecsp pushed a commit to gecsp/lobe-chat that referenced this pull request Dec 26, 2024
@canisminor1990 @gecsp
♻️ refactor: Refactor services code style (lobehub#5180)
af454c0 
* ♻️ refactor: Refactor services code style

* ✅ test: Fix test

* 🐛 fix: Fix review problem
gecsp pushed a commit to gecsp/lobe-chat that referenced this pull request Dec 26, 2024
@semantic-release-bot @gecsp
🔖 chore(release): v1.40.0 [skip ci]
4c2732e 
## [Version&nbsp;1.40.0](lobehub/lobe-chat@v1.39.3...v1.40.0)
<sup>Released on **2024-12-26**</sup>

#### ♻ Code Refactoring

- **misc**: Refactor services code style.

#### ✨ Features

- **misc**: Add changelog modal.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### Code refactoring

* **misc**: Refactor services code style, closes [lobehub#5180](lobehub#5180) ([e98ece8](lobehub@e98ece8))

#### What's improved

* **misc**: Add changelog modal, closes [lobehub#4800](lobehub#4800) ([df3ac87](lobehub@df3ac87))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
github-actions bot pushed a commit to bentwnghk/lobe-chat that referenced this pull request Dec 26, 2024
@semantic-release-bot
🔖 chore(release): v1.82.0 [skip ci]
ab51afe 
## [Version&nbsp;1.82.0](v1.81.2...v1.82.0)
<sup>Released on **2024-12-26**</sup>

#### ♻ Code Refactoring

- **misc**: Refactor services code style.

#### ✨ Features

- **misc**: Add changelog modal.

#### 🐛 Bug Fixes

- **misc**: Fix o1Models list.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### Code refactoring

* **misc**: Refactor services code style, closes [lobehub#5180](https://github.com/bentwnghk/lobe-chat/issues/5180) ([e98ece8](e98ece8))

#### What's improved

* **misc**: Add changelog modal, closes [lobehub#4800](https://github.com/bentwnghk/lobe-chat/issues/4800) ([df3ac87](df3ac87))

#### What's fixed

* **misc**: Fix o1Models list, closes [lobehub#5183](https://github.com/bentwnghk/lobe-chat/issues/5183) ([10d9904](10d9904))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arvinxx arvinxx arvinxx approved these changes

Assignees
No one assigned
Labels
released size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@canisminor1990 @lobehubbot @arvinxx