Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💄 style: add optimistic loading for image uploading #2700

Merged
merged 5 commits into from
May 28, 2024
Merged

💄 style: add optimistic loading for image uploading #2700

merged 5 commits into from
May 28, 2024

Conversation

arvinxx
Copy link
Contributor

@arvinxx arvinxx commented May 28, 2024 •
edited
Loading

💻 变更类型 | Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • ⚡️ perf
  • 📝 docs

🔀 变更说明 | Description of Change

针对开启 S3 的场景下，上传重构为乐观更新模式，进而优化用户体验

📝 补充信息 | Additional Information

refs: #1851

@vercel Vercel
Copy link

vercel bot commented May 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lobe-chat-community ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2024 3:54pm

@lobehubbot
Copy link
Member

👍 @arvinxx

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
非常感谢您提出拉取请求并为我们的社区做出贡献，请确保您已经遵循了我们的贡献指南，我们会尽快审查它。
如果您遇到任何问题，请随时与我们联系。

@codecov Codecov
Copy link

codecov bot commented May 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 94.92754% with 7 lines in your changes missing coverage. Please review.

Project coverage is 94.10%. Comparing base (0dfcf8d) to head (54a451d).
Report is 1045 commits behind head on main.

Files with missing lines Patch % Lines
src/store/file/slices/images/action.ts 91.95% 7 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##             main    #2700    +/-   ##
========================================
  Coverage   94.09%   94.10%            
========================================
  Files         357      357            
  Lines       20591    20696   +105     
  Branches     1585     1592     +7     
========================================
+ Hits        19376    19476   +100     
- Misses       1215     1220     +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arvinxx arvinxx changed the title 🚸 refactor: add optimistic loading for file uploading 🚸 refactor: add optimistic loading for image uploading May 28, 2024
@arvinxx arvinxx changed the title 🚸 refactor: add optimistic loading for image uploading 💄 style: add optimistic loading for image uploading May 28, 2024
@arvinxx arvinxx merged commit f99c9ce into main May 28, 2024
10 checks passed
@arvinxx arvinxx deleted the refactor/files branch May 28, 2024 15:57
@lobehubbot
Copy link
Member

❤️ Great PR @arvinxx ❤️

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.
项目的成长离不开用户反馈和贡献，感谢您的贡献! 如果您对 LobeHub 开发者社区感兴趣，请加入我们的 discord，然后私信 @arvinxx 或 @canisminor1990。他们会邀请您加入我们的私密开发者频道。我们将会讨论关于 Lobe Chat 的开发，分享和讨论全球范围内的 AI 消息。

github-actions bot pushed a commit that referenced this pull request May 28, 2024
@semantic-release-bot
🔖 chore(release): v0.162.8 [skip ci]
3019a0a 
### [Version 0.162.8](v0.162.7...v0.162.8)
<sup>Released on **2024-05-28**</sup>

#### 💄 Styles

- **misc**: Add optimistic loading for image uploading.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### Styles

* **misc**: Add optimistic loading for image uploading, closes [#2700](#2700) ([f99c9ce](f99c9ce))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@lobehubbot
Copy link
Member

🎉 This PR is included in version 0.162.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit to bentwnghk/lobe-chat that referenced this pull request May 28, 2024
@semantic-release-bot
🔖 chore(release): v1.42.4 [skip ci]
65f7e09 
### [Version&nbsp;1.42.4](v1.42.3...v1.42.4)
<sup>Released on **2024-05-28**</sup>

#### 💄 Styles

- **misc**: Add optimistic loading for image uploading, improve display of `set limited history messages`, `randomness` and `voice input`.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### Styles

* **misc**: Add optimistic loading for image uploading, closes [lobehub#2700](https://github.com/bentwnghk/lobe-chat/issues/2700) ([f99c9ce](f99c9ce))
* **misc**: Improve display of `set limited history messages`, `randomness` and `voice input`, closes [lobehub#2586](https://github.com/bentwnghk/lobe-chat/issues/2586) ([22c9b9c](22c9b9c))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
Yanyutin753 added a commit to Yanyutin753/lobe-chat that referenced this pull request May 29, 2024
@Yanyutin753
Revert "💄 style: add optimistic loading for image uploading (lobehub#…
da78d0d 
…2700)"

This reverts commit f99c9ce.
ipoly pushed a commit to ipoly/lobe-chat that referenced this pull request Jul 29, 2024
@arvinxx @ipoly
💄 style: add optimistic loading for image uploading (lobehub#2700)
a1883a8 
* 🚸 refactor: add optimistic loading for file uploading

* ✅ test: fix tests

* 🚸 style: improve error fallback

* ♻️ refactor: improve swr type

* ✅ test: fix tests
ipoly pushed a commit to ipoly/lobe-chat that referenced this pull request Jul 29, 2024
@semantic-release-bot @ipoly
🔖 chore(release): v0.162.8 [skip ci]
beab735 
### [Version&nbsp;0.162.8](lobehub/lobe-chat@v0.162.7...v0.162.8)
<sup>Released on **2024-05-28**</sup>

#### 💄 Styles

- **misc**: Add optimistic loading for image uploading.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### Styles

* **misc**: Add optimistic loading for image uploading, closes [lobehub#2700](lobehub#2700) ([f99c9ce](lobehub@f99c9ce))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arvinxx @lobehubbot