Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💚 fix: fix vercel build #2666

Merged
merged 1 commit into from
May 26, 2024
Merged

💚 fix: fix vercel build #2666

merged 1 commit into from
May 26, 2024

Conversation

arvinxx
Copy link
Contributor

@arvinxx arvinxx commented May 26, 2024

💻 变更类型 | Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • ⚡️ perf
  • 📝 docs

🔀 变更说明 | Description of Change

close #2662

📝 补充信息 | Additional Information

Summary by CodeRabbit

  • Bug Fixes

    • Improved stability of the chat session panel by adding an additional check for width changes.
  • Chores

    • Updated multiple dependencies to their latest versions for enhanced performance and security.

Copy link

vercel bot commented May 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lobe-chat-community ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 26, 2024 9:31am

@lobehubbot
Copy link
Member

👍 @arvinxx

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
非常感谢您提出拉取请求并为我们的社区做出贡献,请确保您已经遵循了我们的贡献指南,我们会尽快审查它。
如果您遇到任何问题,请随时与我们联系。

Copy link

coderabbitai bot commented May 26, 2024

Walkthrough

The recent updates primarily involve version upgrades for various dependencies in the package.json file, ensuring compatibility and leveraging new features or fixes. Additionally, a minor logic enhancement was made in SessionPanel.tsx to improve error handling in the handleSizeChange function.

Changes

File Path Change Summary
package.json Updated versions of multiple dependencies including @aws-sdk, @clerk, @google, @lobehub, @vercel, ahooks, langfuse, posthog-js, react-i18next, react-virtuoso, react-wrap-balancer, @types/react, glob, lint-staged, and tsx.
src/app/(main)/chat/_layout/Desktop/SessionPanel.tsx Enhanced the handleSizeChange function to include an additional check for nextWidth being falsy before proceeding.

Poem

In the realm of code, updates flow,
Dependencies rise, old versions go.
With checks and balances, logic refined,
Our software grows, ever aligned.
A rabbit's touch, swift and bright,
Ensures our code is always right.
🌟🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to full the review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range and nitpick comments (2)
src/app/(main)/chat/_layout/Desktop/SessionPanel.tsx (2)

43-44: LGTM! Consider adding a comment explaining the reason for the falsy check on nextWidth.


Line range hint 50-50: Add updatePreference to the dependency array of the useEffect hook to avoid potential bugs from stale closures.

-  }, [md, cacheExpand]);
+  }, [md, cacheExpand, updatePreference]);
Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 1c185b4 and 60a54d9.
Files selected for processing (2)
  • package.json (6 hunks)
  • src/app/(main)/chat/_layout/Desktop/SessionPanel.tsx (1 hunks)
Additional Context Used
Biome (2)
src/app/(main)/chat/_layout/Desktop/SessionPanel.tsx (2)

5-6: Some named imports are only used as types.


50-50: This hook does not specify all of its dependencies: updatePreference

Additional comments not posted (2)
src/app/(main)/chat/_layout/Desktop/SessionPanel.tsx (1)

Line range hint 5-6: Usage of named imports as types is standard in TypeScript. No action needed.

package.json (1)

Line range hint 87-157: Dependency updates are minor version increments, which are generally safe. However, ensure to test thoroughly to catch any potential issues that might not be immediately apparent.

Copy link

codecov bot commented May 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.74%. Comparing base (7635129) to head (60a54d9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2666   +/-   ##
=======================================
  Coverage   93.74%   93.74%           
=======================================
  Files         352      352           
  Lines       20400    20400           
  Branches     2430     2430           
=======================================
  Hits        19123    19123           
  Misses       1277     1277           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codenamedpkt
Copy link

codenamedpkt commented May 26, 2024

Why package.json dependencies do not uses latest version with the tag ^latest in the file?

@arvinxx arvinxx merged commit cb70e4a into main May 26, 2024
11 checks passed
@arvinxx arvinxx deleted the build/fix-vercel-build branch May 26, 2024 10:37
@lobehubbot
Copy link
Member

❤️ Great PR @arvinxx ❤️

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.
项目的成长离不开用户反馈和贡献,感谢您的贡献! 如果您对 LobeHub 开发者社区感兴趣,请加入我们的 discord,然后私信 @arvinxx@canisminor1990。他们会邀请您加入我们的私密开发者频道。我们将会讨论关于 Lobe Chat 的开发,分享和讨论全球范围内的 AI 消息。

github-actions bot pushed a commit that referenced this pull request May 26, 2024
### [Version&nbsp;0.161.20](v0.161.19...v0.161.20)
<sup>Released on **2024-05-26**</sup>

#### 🐛 Bug Fixes

- **misc**: Fix vercel build.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Fix vercel build, closes [#2666](#2666) ([cb70e4a](cb70e4a))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@lobehubbot
Copy link
Member

🎉 This PR is included in version 0.161.20 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit to bentwnghk/lobe-chat that referenced this pull request May 26, 2024
### [Version&nbsp;1.41.11](v1.41.10...v1.41.11)
<sup>Released on **2024-05-26**</sup>

#### 🐛 Bug Fixes

- **misc**: Fix vercel build.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Fix vercel build, closes [lobehub#2666](https://github.com/bentwnghk/lobe-chat/issues/2666) ([cb70e4a](cb70e4a))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@codenamedpkt
Copy link

I have another versioned 0.161.21 which package.json has modified and once user deploys, always using latest version. How to make push request to you?

ipoly pushed a commit to ipoly/lobe-chat that referenced this pull request Jul 29, 2024
ipoly pushed a commit to ipoly/lobe-chat that referenced this pull request Jul 29, 2024
### [Version&nbsp;0.161.20](lobehub/lobe-chat@v0.161.19...v0.161.20)
<sup>Released on **2024-05-26**</sup>

#### 🐛 Bug Fixes

- **misc**: Fix vercel build.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Fix vercel build, closes [lobehub#2666](lobehub#2666) ([cb70e4a](lobehub@cb70e4a))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Can't deploy on Vercel
3 participants