Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat: support GitHub OAuth #1850

Merged
merged 11 commits into from
Apr 2, 2024
Merged

✨ feat: support GitHub OAuth #1850

merged 11 commits into from
Apr 2, 2024

Conversation

devcxl
Copy link
Contributor

@devcxl devcxl commented Apr 1, 2024

💻 变更类型 | Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • ⚡️ perf
  • 📝 docs

🔀 变更说明 | Description of Change

添加Github OAuth 登陆方式

📝 补充信息 | Additional Information

新增环境变量:GITHUB_CLIENT_ID GITHUB_CLIENT_SECRET

Copy link

vercel bot commented Apr 1, 2024

@devcxl is attempting to deploy a commit to the LobeHub Team on Vercel.

A member of the Team first needs to authorize it.

@lobehubbot
Copy link
Member

👍 @devcxl

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
非常感谢您提出拉取请求并为我们的社区做出贡献,请确保您已经遵循了我们的贡献指南,我们会尽快审查它。
如果您遇到任何问题,请随时与我们联系。

Copy link
Contributor

@arvinxx arvinxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README.zh-CN.md Outdated Show resolved Hide resolved
@devcxl
Copy link
Contributor Author

devcxl commented Apr 2, 2024

@arvinxx 文档已补充

@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


@arvinxx documentation added

@arvinxx
Copy link
Contributor

arvinxx commented Apr 2, 2024

@devcxl OK,录个 demo 看一眼?

@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


@devcxl OK, record a demo and take a look?

@devcxl
Copy link
Contributor Author

devcxl commented Apr 2, 2024

好了,看这个
https://github.com/lobehub/lobe-chat/assets/64475363/9edbe3af-349d-4de0-8efb-e721e6549000

@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Okay, look at this
https://github.com/lobehub/lobe-chat/assets/64475363/9edbe3af-349d-4de0-8efb-e721e6549000

@arvinxx arvinxx changed the title Add GitHub OAuth login method ✨ feat: support GitHub OAuth Apr 2, 2024
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.37%. Comparing base (04d8e53) to head (ee753f1).
Report is 73 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1850      +/-   ##
==========================================
- Coverage   92.57%   90.37%   -2.20%     
==========================================
  Files         239      248       +9     
  Lines       13066    14320    +1254     
  Branches     1562     1627      +65     
==========================================
+ Hits        12096    12942     +846     
- Misses        970     1378     +408     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@arvinxx arvinxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'll merge it. Thanks for your contribution!

@arvinxx arvinxx merged commit caf378b into lobehub:main Apr 2, 2024
3 of 5 checks passed
@lobehubbot
Copy link
Member

❤️ Great PR @devcxl ❤️

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.
项目的成长离不开用户反馈和贡献,感谢您的贡献! 如果您对 LobeHub 开发者社区感兴趣,请加入我们的 discord,然后私信 @arvinxx@canisminor1990。他们会邀请您加入我们的私密开发者频道。我们将会讨论关于 Lobe Chat 的开发,分享和讨论全球范围内的 AI 消息。

@devcxl
Copy link
Contributor Author

devcxl commented Apr 2, 2024

OK

@lobehubbot
Copy link
Member

🎉 This PR is included in version 0.145.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

mosade pushed a commit to mosade/lobe-chat that referenced this pull request Apr 2, 2024
TheNameIsNigel pushed a commit to TheNameIsNigel/lobe-chat that referenced this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants