Fix periodic timers firing only once #87
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a
Timer
withauto_reload
set totrue
(the default) results in the timer callback being invoked just once, not periodic.The problem is that the
Drop
implementation ofTimer
stops the timer, and since thetimer_callback
function constructs aTimer
out of thin air and passes that by value to the timer callbackBox<dyn Fn(Timer)>
the timer gets dropped when the callback ends and stops. Relevant code: https://github.com/lobaro/FreeRTOS-rust/blob/master/freertos-rust/src/timers.rs#L120This was introduced in #57. Previously,
Timer
had adetached
flag that prevented it from being stopped in its destructor in this situation. Instead of trying to revert this this PR changes the API so that timer callbacks get passed in theTimer
by reference. I think this makes more sense than giving ownership of the timer to its own callback.