Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Node 18 + switch from ramda to rambda #326

Merged
merged 2 commits into from
May 27, 2022

Conversation

taymoork2
Copy link
Contributor

@taymoork2 taymoork2 commented May 12, 2022

Thanks to @jrandolf for the original PR #325 this is based off

image

@taymoork2
Copy link
Contributor Author

@lo1tuma, not be a bother, but can I get a review or update?

@lo1tuma
Copy link
Owner

lo1tuma commented May 24, 2022

Hi @taymoork2, sorry for the late reply, but I was on vacation the last two weeks. I hope to find some time this week to take a closer look at this PR and rambda itself.

My first impression is it looks quite good and well maintained. Although it seems like they don’t support importing functions individually. Can you confirm this? Since we don’t use any bundle we won’t profit from thee-shaking.

@taymoork2
Copy link
Contributor Author

@lo1tuma it's all good

My first impression is it looks quite good and well maintained. Although it seems like they don’t support importing functions individually. Can you confirm this? Since we don’t use any bundle we won’t profit from thee-shaking.

From what i can see, Rambda, does not support require('rambda/'). The screenshot above show's the runtime with individually imported functions/the PR, I tested using yalp (aka npm link)

lib/util/ast.js Outdated Show resolved Hide resolved
@lo1tuma
Copy link
Owner

lo1tuma commented May 27, 2022

@taymoork2 I’ve also checked the result of the startup benchmark and it seems like rambda improves the performance by round about 50%, both regarding runtime duration as well as memory usage.

I’ve only found one small issue, once that is fixed I’m happy to merge this PR.

Copy link
Owner

@lo1tuma lo1tuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants