Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freshly coded new client #24

Merged
merged 8 commits into from
Nov 20, 2021
Merged

Conversation

programatik29
Copy link
Contributor

  • Reordered dependencies and removed their patch version.
  • Much more readable and less complex client code.
  • Better implemented timeouts.
  • Better error messages.
  • Use anyhow on client code.
  • Error logging.
  • Uses tokio-native-tls instead of tokio-rustls.

@ChillFish8
Copy link
Member

Ill have to review this tomorrow but any reason for dropping rustls for native tls?

@programatik29
Copy link
Contributor Author

Mainly for convenience on my part. Using native-tls results in less code.

@ChillFish8
Copy link
Member

Bump test

@ChillFish8 ChillFish8 merged commit b54aede into lnx-search:master Nov 20, 2021
@programatik29 programatik29 deleted the new-client branch November 20, 2021 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants