Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper separation of RTM power up and power down responsabilities #204

Closed
augustofg opened this issue Feb 16, 2024 · 0 comments · Fixed by #205
Closed

Proper separation of RTM power up and power down responsabilities #204

augustofg opened this issue Feb 16, 2024 · 0 comments · Fixed by #205

Comments

@augustofg
Copy link
Member

The responsibility of turning on / off the 12V payload power rail should land on the AMC card specific code instead of the RTM driver. The RTM specific code should have 'post power on' and 'pre power down' functions for initialisation / de-initialisation of devices powered by the payload power rail.

I suggest that the functions rtm_enable_payload_power and rtm_disable_payload_power should be migrated from the RTM driver to the AFC RTM functions, make them call rtm_enable_payload_power_post and rtm_disable_payload_power_pre that will be implemented in the RTM driver. Delete the rtm_quisce function to avoid confusion, the modules/rtm.c: RTM_Manage task should call rtm_disable_payload_power instead. Remember to do proper error propagation using the mmc_err type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants