Merge pull request alma-oss#67 from MortalFlesh/feature/add-php74-fixers

Add new ecs_7.4 coding standards for php 7.4+

Author: MortalFlesh

CHANGELOG.md

@@ -6,6 +6,7 @@
 
 ## Unreleased
 - Fix SpecifyArgSeparatorFixer not compatible with php-cs-fixer 3.0.
+- Add new `ecs-7.4.php` coding standard declaration file for PHP 7.4+.
 
 ## 3.1.0 - 2021-05-13
 - Use php-cs-fixer 3.0.

README.md

@@ -26,6 +26,9 @@ use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigura
 
 return static function (ContainerConfigurator $containerConfigurator): void {
     $containerConfigurator->import(__DIR__ . '/vendor/lmc/coding-standard/ecs.php');
+
+    // If you only need PHP 7.4+ in your project, uncomment this to import additional checks:
+    //$containerConfigurator->import(__DIR__ . '/vendor/lmc/coding-standard/ecs-7.4.php');
 };
 ```
 

composer.json

@@ -49,16 +49,16 @@
             "@test"
         ],
         "analyze": [
-            "vendor/bin/ecs check src/ tests/ ecs.php --ansi",
+            "vendor/bin/ecs check src/ tests/ ecs.php ecs-7.4.php --ansi",
             "vendor/bin/ecs check-markdown README.md --ansi",
             "vendor/bin/phpstan analyze -c phpstan.neon --ansi"
         ],
         "fix": [
             "@composer normalize",
-            "vendor/bin/ecs check ./src/ ./tests/ ecs.php --ansi --fix"
+            "vendor/bin/ecs check ./src/ ./tests/ ecs.php ecs-7.4.php --ansi --fix"
         ],
         "lint": [
-            "vendor/bin/parallel-lint -j 10 -e php ./src ./tests ecs.php",
+            "vendor/bin/parallel-lint -j 10 -e php ./src ./tests ecs.php ecs-7.4.php",
             "@composer validate",
             "@composer normalize --dry-run"
         ],

ecs-7.4.php

@@ -0,0 +1,17 @@
+<?php declare(strict_types=1);
+
+use PhpCsFixer\Fixer\FunctionNotation\PhpdocToParamTypeFixer;
+use PhpCsFixer\Fixer\FunctionNotation\PhpdocToPropertyTypeFixer;
+use PhpCsFixer\Fixer\FunctionNotation\PhpdocToReturnTypeFixer;
+use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
+
+return static function (ContainerConfigurator $containerConfigurator): void {
+    $services = $containerConfigurator->services();
+
+    // Takes `@var` annotation of non-mixed types and adjusts accordingly the property signature.
+    $services->set(PhpdocToPropertyTypeFixer::class);
+    // Takes `@param` annotations of non-mixed types and adjusts accordingly the function signature.
+    $services->set(PhpdocToParamTypeFixer::class);
+    // Takes `@return` annotation of non-mixed types and adjusts accordingly the function signature.
+    $services->set(PhpdocToReturnTypeFixer::class);
+};