Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add macos #1

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

add macos #1

wants to merge 1 commit into from

Conversation

aehlke
Copy link

@aehlke aehlke commented Feb 17, 2023

No description provided.

@lm lm self-requested a review February 20, 2023 07:50
@lm
Copy link
Owner

lm commented Feb 21, 2023

Thanks for the contribution. I noticed some incompleteness and incorrect behaviour while testing on MacOS 12:

  • window is missing bar with back button and title
  • root view is misaligned

These are essential features as this package aims to provide complete replacement for newer navigation API.

Could you consider implementing this using SwiftUI NavigationView on MacOS 12?

@aehlke
Copy link
Author

aehlke commented Feb 21, 2023 •
edited
Loading

Thanks for the detailed feedback. I shared WIP, sorry for lack of disclaimer. I'll finish this up.

I'm not sure if I can use NavigationView. I'll look into it.

@lm lm marked this pull request as draft February 22, 2023 07:40
@aehlke
Copy link
Author

aehlke commented Apr 27, 2024

FTR I found this other backport with macOS https://github.com/johnpatrickmorgan/NavigationBackport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lm lm Awaiting requested review from lm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aehlke @lm