[TorchToLinalg] Enable lowering of AtenMaxPool1dWithIndicesOp to linalg dialect #4215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zahidwx
force-pushed
the
feature/Maxpool1dIndices
branch
from
8f7c53a to
d6c3a9b
Compare
zahidwx
changed the title
zahidwx
force-pushed
the
feature/Maxpool1dIndices
branch
from
d592fda to
57d14be
Compare
|
@stellaraccident | @vivekkhandelwal1 | @zjgarvey Can I get a review on this please? |
Signed-off-by: Zahid Wakeel <zahid.wakeel@multicorewareinc.com>
Signed-off-by: Zahid Wakeel <zahid.wakeel@multicorewareinc.com>
Signed-off-by: Zahid Wakeel <zahid.wakeel@multicorewareinc.com>
zahidwx
force-pushed
the
feature/Maxpool1dIndices
branch
from
57d14be to
600c584
Compare
vivekkhandelwal1
approved these changes
Jun 16, 2025
There was a problem hiding this comment.
LGTM! For the stablehlo part, I request @penguin-wwy @qingyunqu to review the changes.
|
Hi @penguin-wwy & @qingyunqu, for stablehlo part can this PR be reviewed? It's been left hanging for some time. Thanks. |
@penguin-wwy @qingyunqu Just a gentle reminder to review this. |
penguin-wwy
approved these changes
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes care of #4214.
AtenMaxPool1dWithIndicesOpto linalg backendAtenMaxPool1dWithIndicesOp