Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TorchToLinalg] NFC: Move Utils.h to an externally accessible location #2603

Merged
merged 1 commit into from
Dec 2, 2023

Conversation

qedawkins
Copy link
Collaborator

No description provided.

@qedawkins qedawkins changed the title [TorchToLinalg] Move Utils.h to an externally accessible location [TorchToLinalg] NFC: Move Utils.h to an externally accessible location Dec 1, 2023
Copy link
Collaborator

@ramiro050 ramiro050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Mind if I ask what the motivation is?

@qedawkins
Copy link
Collaborator Author

LGTM. Mind if I ask what the motivation is?

Downstream IREE composes its own lowering pipeline of the Torch dialect so that we can lower directly to certain IREE ops. Essentially these utils are just useful for doing some of those kinds of lowerings. This isn't really meant to make these utils part of a stable API if that's a concern though.

@qedawkins qedawkins merged commit 400752c into llvm:main Dec 2, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants