python: separate build- and test-related pip dependencies #1874
Conversation
|
@ashay I haven't been tracking this work stream but I might've thrown a small monkey wrench in your works since I refactored |
Oh, no worries at all! I saw your PR and it looks like it will not be too hard to merge. I'm currently waiting for the GitHub builder issue to be resolved, after which I'll rebase. Thanks for the heads up, though! |
We want to ensure that pip packages required for building torch-mlir should be included in the dependencies of torch-mlir, but we don't want the pip packages required for _testing_ of torch-mlir to be included among the dependencies. To be able to specify and install one set of dependencies and not the other, this patch separates the pip packages into two files: build-requirements.txt and test-requirements.txt. This patch also updates references to the requirements.txt file so that CI builds that run end-to-end tests install test-related pip dependencies while everything else (including WHL builds) sticks to just the build-related pip dependencies. Despite this change, this patch should not affect a torch-mlir developer's workflow. More precisely, since this patch makes the top-level requirements.txt file refer to both build-requirements.txt and test-requirements.txt files, a torch-mlir developer should be able to continue referring to the requirements.txt file without any impact.
|
I now have doubts about whether this drops the torchvision dependency from the WHL files. It probably does for the macOS and Windows WHL files but I am not sure about Linux. I am merging it now, and I'll start a one shot release build, but I'll come back to this tomorrow and see if the dependencies are updated as we expect. |
We want to ensure that pip packages required for building torch-mlir should be included in the dependencies of torch-mlir, but we don't want the pip packages required for _testing_ of torch-mlir to be included among the dependencies. To be able to specify and install one set of dependencies and not the other, this patch separates the pip packages into two files: build-requirements.txt and test-requirements.txt. This patch also updates references to the requirements.txt file so that CI builds that run end-to-end tests install test-related pip dependencies while everything else (including WHL builds) sticks to just the build-related pip dependencies. Despite this change, this patch should not affect a torch-mlir developer's workflow. More precisely, since this patch makes the top-level requirements.txt file refer to both build-requirements.txt and test-requirements.txt files, a torch-mlir developer should be able to continue referring to the requirements.txt file without any impact.
We want to ensure that pip packages required for building torch-mlir
should be included in the dependencies of torch-mlir, but we don't want
the pip packages required for testing of torch-mlir to be included
among the dependencies. To be able to specify and install one set of
dependencies and not the other, this patch separates the pip packages
into two files: build-requirements.txt and test-requirements.txt.
This patch also updates references to the requirements.txt file so that
CI builds that run end-to-end tests install test-related pip
dependencies while everything else (including WHL builds) sticks to just
the build-related pip dependencies.
Despite this change, this patch should not affect a torch-mlir
developer's workflow. More precisely, since this patch makes the
top-level requirements.txt file refer to both build-requirements.txt and
test-requirements.txt files, a torch-mlir developer should be able to
continue referring to the requirements.txt file without any impact.