-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Windows CI and Release Builder #1521
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, this looks good, but let me try out the PowerShell script at my end, just to make sure nothing breaks.
Side note: this os/arch customization is getting too hairy, but after your PR lands, I'll try and refactor this to be easier to read and to reuse scripts more often.
e37c94e
to
16837b3
Compare
if your run the |
6a0b966
to
2dc9277
Compare
Add a powershell script to build windows .whl packages Disable LTC as it doesn't build on Windows. Add GHA hooks Use Python 3.10.8
2dc9277
to
03ddcf4
Compare
@ashay I just made the CI build for now. The tests were getting wonky with paths etc. So once this lands we can clean up and get e2e tests running. I think we can still use the pip path to build. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! This sure looks like a lot of work, but I'm glad this finally builds. We'll clean it up in the coming weeks.
Overly specific docs can get stale easily. It looks like https://llvm.github.io/torch-mlir/package-index/ has included Windows packages since around #1521. Here's an example release: https://github.com/llvm/torch-mlir/releases/tag/snapshot-20240118.1087 ``` torch-2.3.0.dev20240109+cpu-cp311-cp311-linux_x86_64.whl torch-2.3.0.dev20240109+cpu-cp311-cp311-win_amd64.whl torch-2.3.0.dev20240109+cpu-cp38-cp38-linux_x86_64.whl torch-2.3.0.dev20240109-cp311-cp311-manylinux_2_17_aarch64.manylinux2014_aarch64.whl torch-2.3.0.dev20240109-cp311-none-macosx_10_9_x86_64.whl torch_mlir-20240118.1087-cp311-cp311-linux_aarch64.whl torch_mlir-20240118.1087-cp311-cp311-linux_x86_64.whl torch_mlir-20240118.1087-cp311-cp311-macosx_11_0_universal2.whl torch_mlir-20240118.1087-cp311-cp311-win_amd64.whl torch_mlir-20240118.1087-cp38-cp38-linux_x86_64.whl ```
Add a powershell script to build windows .whl packages Disable LTC as it doesn't build on Windows.
This works on my local Windows 11 setup. Will try to invoke from GHA next.