Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows CI and Release Builder #1521

Merged
merged 1 commit into from
Oct 25, 2022
Merged

Add Windows CI and Release Builder #1521

merged 1 commit into from
Oct 25, 2022

Conversation

powderluv
Copy link
Collaborator

Add a powershell script to build windows .whl packages Disable LTC as it doesn't build on Windows.

This works on my local Windows 11 setup. Will try to invoke from GHA next.

@powderluv powderluv requested a review from ashay October 24, 2022 20:45
Copy link
Collaborator

@ashay ashay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, this looks good, but let me try out the PowerShell script at my end, just to make sure nothing breaks.

Side note: this os/arch customization is getting too hairy, but after your PR lands, I'll try and refactor this to be easier to read and to reuse scripts more often.

@powderluv powderluv force-pushed the win-release-builder branch from e37c94e to 16837b3 Compare October 25, 2022 05:51
@powderluv
Copy link
Collaborator Author

if your run the build_windows.ps1 and build_windows_ci.ps1 you can run the Windows CI and Release build locally.

@powderluv powderluv force-pushed the win-release-builder branch 2 times, most recently from 6a0b966 to 2dc9277 Compare October 25, 2022 16:09
@powderluv powderluv changed the title [wip] Add Windows Builder Add Windows Builder Oct 25, 2022
@powderluv powderluv changed the title Add Windows Builder Add Windows CI and Release Builder Oct 25, 2022
@powderluv powderluv requested a review from ashay October 25, 2022 17:53
Add a powershell script to build windows .whl packages
Disable LTC as it doesn't build on Windows.
Add GHA hooks
Use Python 3.10.8
@powderluv powderluv force-pushed the win-release-builder branch from 2dc9277 to 03ddcf4 Compare October 25, 2022 20:01
@powderluv
Copy link
Collaborator Author

@ashay I just made the CI build for now. The tests were getting wonky with paths etc. So once this lands we can clean up and get e2e tests running. I think we can still use the pip path to build.

Copy link
Collaborator

@ashay ashay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! This sure looks like a lot of work, but I'm glad this finally builds. We'll clean it up in the coming weeks.

@powderluv powderluv merged commit bbde4e1 into main Oct 25, 2022
@powderluv powderluv deleted the win-release-builder branch October 25, 2022 23:13
ScottTodd added a commit that referenced this pull request Jan 19, 2024
Overly specific docs can get stale easily. It looks like
https://llvm.github.io/torch-mlir/package-index/ has included Windows
packages since around #1521.

Here's an example release:
https://github.com/llvm/torch-mlir/releases/tag/snapshot-20240118.1087

```
torch-2.3.0.dev20240109+cpu-cp311-cp311-linux_x86_64.whl
torch-2.3.0.dev20240109+cpu-cp311-cp311-win_amd64.whl
torch-2.3.0.dev20240109+cpu-cp38-cp38-linux_x86_64.whl
torch-2.3.0.dev20240109-cp311-cp311-manylinux_2_17_aarch64.manylinux2014_aarch64.whl
torch-2.3.0.dev20240109-cp311-none-macosx_10_9_x86_64.whl
torch_mlir-20240118.1087-cp311-cp311-linux_aarch64.whl
torch_mlir-20240118.1087-cp311-cp311-linux_x86_64.whl
torch_mlir-20240118.1087-cp311-cp311-macosx_11_0_universal2.whl
torch_mlir-20240118.1087-cp311-cp311-win_amd64.whl
torch_mlir-20240118.1087-cp38-cp38-linux_x86_64.whl
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants