Force double precision in aten.mean.dim#1308
Closed
Conversation
qedawkins
force-pushed
the
mean_dim_f64
branch
3 times, most recently
from
831ff2e to
a7fddc0
Compare
ramiro050
reviewed
Aug 29, 2022
qedawkins
force-pushed
the
mean_dim_f64
branch
from
a7fddc0 to
741c123
Compare
Collaborator
|
Looks like Refbackend fails to run the test on GHA ? Should we skip it by default ? |
Collaborator
|
Is the error not reproducible locally? |
qedawkins
pushed a commit
to nod-ai/torch-mlir
that referenced
this pull request
Oct 3, 2022
…lvm#1308) Signed-off-by: Whitney Tsang <whitneyt@ca.ibm.com>
qedawkins
pushed a commit
to nod-ai/torch-mlir
that referenced
this pull request
Oct 3, 2022
The modification to use the builder based interface to generate Krnl loop is completed (llvm#1250, llvm#1283, llvm#1285, llvm#1292, llvm#1293, llvm#1303, llvm#1308, llvm#1314, llvm#1316, llvm#1317, llvm#1326, llvm#1403), and BuildKrnlLoop is no longer needed. Signed-off-by: Whitney Tsang whitneyt@ca.ibm.com
Collaborator
Author
|
Closing as this is fixed by #1605 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accuracy for aten.mean.dim was off for large inputs for the same reason as aten.var.correction (see #1100)