Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

importer: add initial support for loading Float16 tensors #1169

Merged
merged 1 commit into from
Aug 8, 2022

Conversation

tanyokwok
Copy link
Collaborator

@tanyokwok tanyokwok commented Aug 8, 2022

follow up #761:

This patch updates the torch_mlir::convertTensorToMlirElementsAttr()
method to enable the creation of tensors whose base type is Float16.
This patch also adds a test to validate the IR generation, and it
updates the test for importing tensors of various types.

follow up llvm#761:

    This patch updates the `torch_mlir::convertTensorToMlirElementsAttr()`
    method to enable the creation of tensors whose base type is Float16.
    This patch also adds a test to validate the IR generation, and it
    updates the test for importing tensors of various types.
Copy link
Collaborator

@ashay ashay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tanyokwok tanyokwok merged commit 290d775 into llvm:main Aug 8, 2022
@tanyokwok tanyokwok deleted the tanyo/fix_fp16 branch August 8, 2022 04:37
@tanyokwok
Copy link
Collaborator Author

@ashay Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants