[BOLT] Mark build skipped when tests did not run #468
+89
−91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NFC-mode runs in-tree and out-of-tree (large BOLT tests) when there are changes affecting llvm-bolt between the current revision and the previous one. However, the revision SHA itself and the GNU build-id may be two unique differences when doing such a comparison. This patch introduces a lightweight sanity check step that reports a warning on the Buildbot so that we are aware when this occurs.
Pass '--build-id' to the linker to disable emission of a unique build ID into a note section. This breaks nfc-mode tests. Additional cleanup: - Out-of-tree tests are now labeled as 'BOLT large tests' - Dropped step 'nfc-stat-check' as it was disabled - Removed unused flags for Non-NFC tests
When setting up the nfc-mode tests, avoid adding an extra pair of in-tree and out-of-tree tests that were unconditional. This was previously done with addNinjaSteps. Instead, add those later and make them conditional on llvm-bolt being modified. Since tests are now only added by BOLTBuilder: - `ninja` runs the in-tree tests to correctly build dependencies. - flunkOnFailure is set to update the build status on failures. Some nits: - the '--switch-back' flag is used (from nfc-check-setup.py). - a 'nfc-' prefix is appended to 'check-bolt-different' step - remove timing.log cleanup
Use `--check-bolt-sources` from nfc-check-setup.py to run tests when source files change between the current and previous revisions. This triggers only in-tree tests. When the llvm-bolt binary changes, both in-tree and out-of-tree tests are run.
If in-tree tests do not run, mark the whole build as skipped. Note that when this happens, out-of-tree tests also do not run. This helps when navigating Buildbot's build requests: - Skipped builds indicate the change was unrelated to BOLT. - Any other errors are still reported. - For breaking changes that need reversal, builds will show as SKIPPED or FAILURE depending on whether llvm-bolt was affected, instead of SUCCESS or FAILURE, which can be confusing.
|
This PR aims to make navigating completed build requests more efficient, and less confusing. Note that the WARNINGS won't be displayed once these patches are merged (see discourse post). An updated table with example patches after this feature:
|
paschalis-mpeis
force-pushed
the
users/paschalis-mpeis/increase-test-coverage
branch
from
8f4aaf1 to
326abf3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If in-tree tests do not run, mark the whole build as skipped. Note that when this happens, out-of-tree tests also do not run.
This helps when navigating Buildbot's build requests: