[lldb][test] Fix type error when calling random.randrange with 'float' arg

[kendalharland]

This test only runs on Windows and fails because we're passing a literal of the wrong type to random.randrange.

[github-actions]

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be
notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write
permissions for the repository. In which case you can instead tag reviewers by
name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review
by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate
is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

[llvmbot]

@llvm/pr-subscribers-lldb

Author: Kendal Harland (kendalharland)

Changes

This test only runs on Windows and fails because we're passing a literal of the wrong type to random.randrange.

---

Full diff: https://github.com/llvm/llvm-project/pull/97328.diff

1 Files Affected:

• (modified) lldb/test/API/tools/lldb-server/commandline/TestGdbRemoteConnection.py (+1-1)

diff --git a/lldb/test/API/tools/lldb-server/commandline/TestGdbRemoteConnection.py b/lldb/test/API/tools/lldb-server/commandline/TestGdbRemoteConnection.py
index 853b7ad5ef290..f31a57b767c72 100644
--- a/lldb/test/API/tools/lldb-server/commandline/TestGdbRemoteConnection.py
+++ b/lldb/test/API/tools/lldb-server/commandline/TestGdbRemoteConnection.py
@@ -75,7 +75,7 @@ def __init__(self):
     class Pipe(object):
         def __init__(self, prefix):
             while True:
-                self.name = "lldb-" + str(random.randrange(1e10))
+                self.name = "lldb-" + str(random.randrange(int(1e10)))
                 full_name = "\\\\.\\pipe\\" + self.name
                 self._handle = CreateNamedPipe(
                     full_name,

[JDevlieghere]

How about random.randrange(10000000000)?

[kendalharland]

I would prefer to leave it as the original author wrote it if that's alright. I'm assuming they found the shorthand more readable

[DavidSpickett]

FWIW I find it easier to read e10 than 0000000000, so I'd also keep the style as is.

[labath]

How about 10**10 ?

(As the "original author" ;), I'm not really sure what happened here. I'm pretty sure I did not write a huge blob of windows-specific code without testing it. It could be that newer python versions got more strict about typing or sth...)

[DavidSpickett]

I'm confused, I don't see this random call in TestGdbRemoteConnection.py, but I do in lldb/packages/Python/lldbsuite/test/tools/lldb-server/lldbgdbserverutils.py.

Is your branch based off something other than the current main?

[labath]

Looks good, but note that this file was moved (to packages/Python/lldbsuite/test/tools/lldb-server/lldbgdbserverutils.py) recently, so you'll need to rebase this PR to HEAD.

[labath]

How about 10**10 ?

(As the "original author" ;), I'm not really sure what happened here. I'm pretty sure I did not write a huge blob of windows-specific code without testing it. It could be that newer python versions got more strict about typing or sth...)

[kendalharland]

Using 10**10. Works for me. Updated and rebased on top of main.

[kendalharland]

I'll also need help merging this since I don't have write access to the repo.

[github-actions]

@kendalharland Congratulations on having your first Pull Request (PR) merged into the LLVM Project!

Your changes will be combined with recent changes from other authors, then tested
by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR.

Please check whether problems have been caused by your change specifically, as
the builds can include changes from many authors. It is not uncommon for your
change to be included in a build that fails due to someone else's changes, or
infrastructure issues.

How to do this, and the rest of the post-merge process, is covered in detail here.

If your change does cause a problem, it may be reverted, or you can revert it yourself.
This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again.

If you don't get any reports, no action is required from you. Your changes are working as expected, well done!