Skip to content

[clang][Sema] Add missing scope flags to Scope::dumpImpl#94529

Merged
kparzysz merged 1 commit into
llvm:mainfrom
kparzysz:users/kparzysz/clang-scope-flags
Jun 6, 2024
Merged

[clang][Sema] Add missing scope flags to Scope::dumpImpl#94529
kparzysz merged 1 commit into
llvm:mainfrom
kparzysz:users/kparzysz/clang-scope-flags

Conversation

@kparzysz
Copy link
Copy Markdown
Contributor

@kparzysz kparzysz commented Jun 5, 2024

There were a handlful of scope flags that were not handled in the dump function, which would then lead to an assert.

There were a handlful of scope flags that were not handled in the dump
function, would would then lead to an assert.
@kparzysz kparzysz requested review from cor3ntin and erichkeane June 5, 2024 19:50
@llvmbot llvmbot added clang Clang issues not falling into any other category clang:frontend Language frontend issues, e.g. anything involving "Sema" labels Jun 5, 2024
@llvmbot
Copy link
Copy Markdown
Member

llvmbot commented Jun 5, 2024

@llvm/pr-subscribers-clang

Author: Krzysztof Parzyszek (kparzysz)

Changes

There were a handlful of scope flags that were not handled in the dump function, would would then lead to an assert.


Full diff: https://github.com/llvm/llvm-project/pull/94529.diff

1 Files Affected:

  • (modified) clang/lib/Sema/Scope.cpp (+4)
diff --git a/clang/lib/Sema/Scope.cpp b/clang/lib/Sema/Scope.cpp
index c08073e80ff3d..5bc7e79a68186 100644
--- a/clang/lib/Sema/Scope.cpp
+++ b/clang/lib/Sema/Scope.cpp
@@ -228,7 +228,11 @@ void Scope::dumpImpl(raw_ostream &OS) const {
       {CompoundStmtScope, "CompoundStmtScope"},
       {ClassInheritanceScope, "ClassInheritanceScope"},
       {CatchScope, "CatchScope"},
+      {ConditionVarScope, "ConditionVarScope"},
+      {OpenMPOrderClauseScope, "OpenMPOrderClauseScope"},
+      {LambdaScope, "LambdaScope"},
       {OpenACCComputeConstructScope, "OpenACCComputeConstructScope"},
+      {TypeAliasScope, "TypeAliasScope"},
       {FriendScope, "FriendScope"},
   };
 

@kparzysz kparzysz merged commit c5c530f into llvm:main Jun 6, 2024
@kparzysz kparzysz deleted the users/kparzysz/clang-scope-flags branch June 6, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clang:frontend Language frontend issues, e.g. anything involving "Sema" clang Clang issues not falling into any other category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants